Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak adapter config CHANGELOG #7853

Merged
merged 2 commits into from
Jul 28, 2023
Merged

Tweak adapter config CHANGELOG #7853

merged 2 commits into from
Jul 28, 2023

Conversation

delucis
Copy link
Member

@delucis delucis commented Jul 28, 2023

Changes

Reworks the CHANGELOG for recent changes to the adapter/build config API. Now looks like this:

The build.split and build.excludeMiddleware configuration options are deprecated and have been replaced by options in the adapter config.

If your config includes the build.excludeMiddleware option, replace it with edgeMiddleware in your adapter options:

import {defineConfig} from "astro/config";
import netlify from "@astrojs/netlify/functions";

export default defineConfig({
     build: {
-        excludeMiddleware: true
     },
     adapter: netlify({
+        edgeMiddleware: true
     }),
});

If your config includes the build.split option, replace it with functionPerRoute in your adapter options:

import {defineConfig} from "astro/config";
import netlify from "@astrojs/netlify/functions";

export default defineConfig({
     build: {
-        split: true
     },
     adapter: netlify({
+        functionPerRoute: true
     }),
});

Testing

n/a

Docs

/cc @withastro/maintainers-docs for feedback!

@changeset-bot
Copy link

changeset-bot bot commented Jul 28, 2023

⚠️ No Changeset found

Latest commit: 264c68d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @delucis ! 🙏

@ematipico ematipico merged commit 93e35d8 into next Jul 28, 2023
@ematipico ematipico deleted the chris/changelog-tweak branch July 28, 2023 12:10
ematipico pushed a commit that referenced this pull request Jul 31, 2023
ematipico pushed a commit that referenced this pull request Aug 1, 2023
ematipico pushed a commit that referenced this pull request Aug 1, 2023
ematipico pushed a commit that referenced this pull request Aug 3, 2023
ematipico pushed a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants