Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro compiler): check vite command to decide on "annotateSourceFile" #9275

Merged
merged 3 commits into from
Dec 4, 2023

Conversation

lilnasy
Copy link
Contributor

@lilnasy lilnasy commented Dec 3, 2023

Changes

Prevents source file and location annotations appearing on every element in the build.

Testing

Small change, manually tested

Docs

Does not affect usage

Copy link

changeset-bot bot commented Dec 3, 2023

🦋 Changeset detected

Latest commit: ac752e3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 3, 2023
@lilnasy lilnasy force-pushed the prod-annotations-fix branch from 98ac4a1 to 5e793f8 Compare December 4, 2023 15:08
@lilnasy lilnasy changed the title fix(astro compiler): check vite mode to decide on "annotateSourceFile" fix(astro compiler): check vite command to decide on "annotateSourceFile" Dec 4, 2023
Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lilnasy lilnasy force-pushed the prod-annotations-fix branch from a3918ff to 2e8575b Compare December 4, 2023 16:59
@FredKSchott
Copy link
Member

Introduced a merge conflict in #9291 just now, sorry! Should be quick to resolve, just renaming devOverlay to devToolbar

@lilnasy lilnasy force-pushed the prod-annotations-fix branch from 2e8575b to ac752e3 Compare December 4, 2023 19:46
@lilnasy lilnasy merged commit 0968cb1 into withastro:main Dec 4, 2023
@lilnasy lilnasy deleted the prod-annotations-fix branch December 4, 2023 19:59
This was referenced Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants