Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Algolia Docsearch to 3.5.1 #10611

Merged
merged 1 commit into from
Jan 4, 2025
Merged

Pin Algolia Docsearch to 3.5.1 #10611

merged 1 commit into from
Jan 4, 2025

Conversation

delucis
Copy link
Member

@delucis delucis commented Jan 4, 2025

This PR reverts the Algolia Docsearch dependencies to 3.5.1

#10493 updated these to 3.8.2, which @hippotastic and @OliverSpeir reported introduced issues in Safari on iOS.

I’m not 100% sure what in that update would cause this and can’t reproduce myself, so opening this PR to see if a revert would help.

@delucis delucis added the site improvement Some thing that improves the website functionality - ask @delucis for help! label Jan 4, 2025
Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit 6376051
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/67796bd1dcdb6a0008f45540
😎 Deploy Preview https://deploy-preview-10611--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@OliverSpeir
Copy link
Contributor

algolia/docsearch#2243

@delucis
Copy link
Member Author

delucis commented Jan 4, 2025

algolia/docsearch#2243

Ah, good find! Version does 3.5.1 predate that issue (3.6.0 was the latest release at that time), but I guess we’ll see if this helps or not…

@OliverSpeir
Copy link
Contributor

This help for me, on iOS 18.2

@delucis delucis marked this pull request as ready for review January 4, 2025 17:22
@hippotastic
Copy link
Contributor

hippotastic commented Jan 4, 2025

This also solves the issue for me. I can scroll down and still open the search in this version. Safari iOS 18.1.1 here.

@delucis delucis merged commit 39e1891 into main Jan 4, 2025
11 checks passed
@delucis delucis deleted the chris/pin-docsearch branch January 4, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
site improvement Some thing that improves the website functionality - ask @delucis for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants