Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update directives-reference.mdx with optional root margin #6038

Merged
merged 5 commits into from
Jan 4, 2024
Merged

Update directives-reference.mdx with optional root margin #6038

merged 5 commits into from
Jan 4, 2024

Conversation

3ddyBoi
Copy link
Contributor

@3ddyBoi 3ddyBoi commented Jan 2, 2024

Documentation for optional root margin on client visible. This documents this pr withastro/astro#9363

Description (required)

This documents the PR withastro/astro#9363 for astro. It shouldn't be merged before the PR is merged. The change is for having root margin as a possiblity.

Related issues & labels (optional)

  • Suggested label: merge-on-release, add new content,

@3ddyBoi
Update directives-reference.mdx with optional root margin
8dbac81 
Documentation for optional root margin on client visible.
This documents this pr withastro/astro#9363
@vercel Vercel
Copy link

vercel bot commented Jan 2, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview Jan 4, 2024 2:35am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) Visit Preview Jan 4, 2024 2:35am

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Netlify 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@sarah11918 sarah11918 added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. labels Jan 2, 2024
@sarah11918 sarah11918 added this to the 4.1.0 milestone Jan 2, 2024
sarah11918
sarah11918 approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this great contribution, @3ddyBoi ! I've just tightened up some of the wording to make it more consistent with the other sections. I also added our special component for indicating when a feature was added. (We don't write "new" in the docs because... when is it no longer new? Will we remember to go back and remove it when it's no longer "new"?) It's more helpful for readers to know exactly which version this was introduced so they know whether it's available in their version of Astro!

This will be ready for tomorrow's 4.1 minor release, and we are pleased to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 3, 2024
yanthomasdev
yanthomasdev approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the great work 🚀

@sarah11918 sarah11918 removed the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 3, 2024
@sarah11918 sarah11918 removed this from the 4.1.0 milestone Jan 3, 2024
@Princesseuh
Copy link
Member

Updated the PR to reflect the new syntax introduced in this PR in core: withastro/astro#9596

@sarah11918 sarah11918 added this to the 4.1.0 milestone Jan 3, 2024
@sarah11918 sarah11918 added the minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! label Jan 3, 2024
@sarah11918 sarah11918 changed the base branch from main to 4.1.0 January 3, 2024 19:59
@sarah11918 sarah11918 merged commit 1d00378 into withastro:4.1.0 Jan 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev Awaiting requested review from yanthomasdev

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@3ddyBoi @astrobot-houston @Princesseuh @sarah11918 @yanthomasdev