Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix progress bar feedback when generating customers via WP-CLI #141

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Fix progress bar feedback when generating customers via WP-CLI #141

merged 1 commit into from
Jul 29, 2024

Conversation

thetwopct
Copy link
Contributor

All Submissions:

Changes proposed in this Pull Request:

When generating customers via WP-CLI the plugin incorrectly states that coupons are being generated before the progress bar.

Screenshot-2024-07-27 --22 11 25

Screenshot-2024-07-27 --22 11 25

This PR fixes the text feedback for the progress bar.

How to test the changes in this Pull Request:

  1. Run wp-cli command wp wc generate customers 1
  2. Check the feedback given on screen

Changelog entry

Fixes progress bar feedback when generating customers via WP-CLI

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

Copy link
Contributor

@coreymckrill coreymckrill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Arg, thank you for catching that copy pasta mistake!

@coreymckrill coreymckrill merged commit d032938 into woocommerce:trunk Jul 29, 2024
@thetwopct thetwopct deleted the thetwopct-patch-1 branch July 31, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants