Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for campaign order attribution data. #146

Merged
merged 5 commits into from
Dec 5, 2024

Conversation

rawdreeg
Copy link
Contributor

@rawdreeg rawdreeg commented Dec 3, 2024

All Submissions:

Changes proposed in this Pull Request:

This PR adds campaign-specific attributes to the order attribution data.

How to test the changes in this Pull Request:

  1. Using this branch, generate at least 500 orders
  2. Follow the steps to test Woo Analytics Order Attribution reports ( woocommercep2.wordpress.com/2024/12/03/order-attribution-reports-hpos-and-non-hpos-support-internal-call-for-testing#how-do-i-test)
  3. Once connected, review the report, filter by Campaigns, and confirm there are campaign data,

Other information:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you successfully run tests with your changes locally?

Changelog entry

Add - Support for campaign order attribution data

FOR PR REVIEWER ONLY:

  • I have reviewed that everything is sanitized/escaped appropriately for any SQL or XSS injection possibilities. I made sure Linting is not ignored or disabled.

@rawdreeg rawdreeg marked this pull request as ready for review December 4, 2024 10:31
@ibndawood
Copy link

Thank you, @rawdreeg, for the feature. Does this mean that every generated order is part of a campaign? If so, I recommend refactoring the code so that about 15% of the generated orders are part of the campaigns. 15% is arbitrary. This would make the generated orders close to reality.

@rawdreeg
Copy link
Contributor Author

rawdreeg commented Dec 4, 2024

@ibndawood, thanks for your review. I reworked the PR to improve campaign distributions in the order generated. I also improved the data variability. Let me know what you think.

Copy link

@ibndawood ibndawood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @rawdreeg, this is neat 👍

@rawdreeg rawdreeg merged commit ce9e396 into trunk Dec 5, 2024
@rawdreeg rawdreeg deleted the add/add-support-for-utm-order-data branch December 5, 2024 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants