Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating min required versions constants #3924

Merged
merged 19 commits into from
Feb 28, 2025
Merged

Updating min required versions constants #3924

merged 19 commits into from
Feb 28, 2025

Conversation

wjrosa
Copy link
Contributor

@wjrosa wjrosa commented Feb 20, 2025 •
edited
Loading

Changes proposed in this Pull Request:

This PR just updates some of our constants to match the latest versions we are currently using for PHP, WC, and WordPress.

Testing instructions

Code review is enough. Check if the tests are still passing.

  • Covered with tests (or have a good reason not to test in description ☝️)
  • Tested on mobile (or does not apply)

Changelog entry

  • Automatically create a changelog entry from the details below.
  • This Pull Request does not require a changelog entry. (Comment required below)
Changelog Entry Details

Type

  • Fix - Fixes an existing bug
  • Add - Adds functionality
  • Update - Update existing functionality
  • Dev - Development related task
  • Tweak - A minor adjustment to the codebase

Message

Changelog Entry Comment

Comment

Post merge

@wjrosa wjrosa self-assigned this Feb 20, 2025
@wjrosa wjrosa marked this pull request as ready for review February 20, 2025 20:59
@wjrosa wjrosa requested review from a team and annemirasol and removed request for a team February 20, 2025 20:59
annemirasol
annemirasol approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@annemirasol annemirasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wjrosa
Copy link
Contributor Author

wjrosa commented Feb 20, 2025

LGTM!

Thanks, Anne! I have no idea why tests are falling, but I will check that before merging.

@annemirasol annemirasol mentioned this pull request Feb 21, 2025
Merged
12 tasks
@wjrosa wjrosa enabled auto-merge (squash) February 25, 2025 19:24
@wjrosa wjrosa force-pushed the dev/updating-min-required-versions-constants branch from 4739bdf to 56e8c60 Compare February 28, 2025 21:19
@wjrosa wjrosa disabled auto-merge February 28, 2025 21:27
@wjrosa wjrosa enabled auto-merge (squash) February 28, 2025 21:27
@wjrosa wjrosa closed this Feb 28, 2025
auto-merge was automatically disabled February 28, 2025 21:27

Pull request was closed

@wjrosa wjrosa reopened this Feb 28, 2025
@wjrosa wjrosa force-pushed the dev/updating-min-required-versions-constants branch from 2afb2cd to 38533f6 Compare February 28, 2025 21:36
@wjrosa wjrosa enabled auto-merge (squash) February 28, 2025 21:48
@wjrosa wjrosa merged commit 0c51fcc into develop Feb 28, 2025
36 of 37 checks passed
@wjrosa wjrosa deleted the dev/updating-min-required-versions-constants branch February 28, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annemirasol annemirasol annemirasol approved these changes

Assignees

@wjrosa wjrosa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wjrosa @annemirasol