Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message for wrong secrets / environment config #4359

Conversation

6543
Copy link
Member

@6543 6543 commented Nov 11, 2024

also address #4306

Before

image
image

After

image
image

@6543 6543 added enhancement improve existing features skip-changelog labels Nov 11, 2024
@6543 6543 changed the title Fail with error to understand On wrong environment config syntax, fail with error to understand Nov 11, 2024
@6543 6543 changed the title On wrong environment config syntax, fail with error to understand On wrong secrets/environment config syntax, fail with good error message Nov 11, 2024
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 91.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.37%. Comparing base (a1193f0) to head (26e8f2f).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pipeline/frontend/yaml/types/base/deprecations.go 91.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4359      +/-   ##
==========================================
+ Coverage   27.32%   27.37%   +0.05%     
==========================================
  Files         379      380       +1     
  Lines       27757    27781      +24     
==========================================
+ Hits         7584     7606      +22     
- Misses      19488    19490       +2     
  Partials      685      685              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xoxys
Copy link
Member

xoxys commented Nov 12, 2024

Shouldn't it go to the changelog? Or why have you set the skip-changelog label?

@6543
Copy link
Member Author

6543 commented Nov 12, 2024

this not as it just improves an already existing error message ... folowups in this area do

Copy link
Member

@xoxys xoxys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adjusted the wording a bit to include most required information to fix it in the log message already.

What might be a bit confusing (e.g. for next users) is that the current docs link does not show the deprecation of secrets as it targets the 2.7.x docs.

@6543 6543 requested a review from xoxys November 13, 2024 12:50
@6543 6543 merged commit 4ed5e4e into woodpecker-ci:main Nov 13, 2024
9 checks passed
@6543 6543 deleted the linter-container-deprecations-refactor-frontport branch November 13, 2024 13:07
@woodpecker-bot
Copy link
Contributor

@anbraten anbraten changed the title On wrong secrets/environment config syntax, fail with good error message Improve error message for wrong secrets / environment config Nov 13, 2024
@woodpecker-bot woodpecker-bot mentioned this pull request Nov 13, 2024
1 task
@woodpecker-bot woodpecker-bot mentioned this pull request Dec 14, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improve existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants