-
-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve error message for wrong secrets / environment config #4359
Improve error message for wrong secrets / environment config #4359
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4359 +/- ##
==========================================
+ Coverage 27.32% 27.37% +0.05%
==========================================
Files 379 380 +1
Lines 27757 27781 +24
==========================================
+ Hits 7584 7606 +22
- Misses 19488 19490 +2
Partials 685 685 ☔ View full report in Codecov by Sentry. |
Shouldn't it go to the changelog? Or why have you set the skip-changelog label? |
this not as it just improves an already existing error message ... folowups in this area do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adjusted the wording a bit to include most required information to fix it in the log message already.
What might be a bit confusing (e.g. for next
users) is that the current docs link does not show the deprecation of secrets
as it targets the 2.7.x
docs.
Co-authored-by: Robert Kaussow <[email protected]>
Tearing down https://woodpecker-ci-woodpecker-pr-4359.surge.sh |
also address #4306
Before
After