Skip to content

Commit

Permalink
refactor: TODO 주석 삭제
Browse files Browse the repository at this point in the history
  • Loading branch information
seokjin8678 committed Jan 10, 2024
1 parent b16a0f6 commit 6e51df2
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ private Member signUp(UserInfo userInfo) {
return memberRepository.save(userInfo.toMember());
}

// TODO FCM 삭제를 위해 DeleteMemberEvent 발행 고려
public void deleteMember(Long memberId) {
Member member = memberRepository.getOrThrow(memberId);
logDeleteMember(member);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import com.festago.ticketing.domain.EntryState;
import com.festago.ticketing.domain.MemberTicket;

// TODO Record 클래스로 바꿔도 좋을듯
public class EntryCodePayload {

private final Long memberTicketId;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
@Transactional
public class MemberFCMService {

// TODO @Slf4j 어노테이션 사용하면 어떨까요
private static final Logger log = LoggerFactory.getLogger(MemberFCMService.class);

private final MemberFCMRepository memberFCMRepository;
Expand All @@ -37,10 +36,6 @@ public MemberFCMsResponse findMemberFCM(Long memberId) {
return MemberFCMsResponse.from(memberFCM);
}

// TODO 사용하지 않는 메서드 같음
// 비즈니스 파라미터의 isNewMember가 애매한 것 같음.
// 다른 회원이 같은 FCM 토큰을 저장하면??
// existsByFcmToken으로 Validation 고려해도 좋을듯 ex) 이미 사용중인 토큰입니다.
@Async
public void saveMemberFCM(boolean isNewMember, String accessToken, String fcmToken) {
if (isNewMember) {
Expand Down Expand Up @@ -68,7 +63,6 @@ private Long extractMemberId(String accessToken) {
return authPayload.getMemberId();
}

// TODO 사용하지 않는 메서드 같음
@Async
public void deleteMemberFCM(Long memberId) {
memberFCMRepository.deleteAllByMemberId(memberId);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
public class FestivalService {

private final FestivalRepository festivalRepository;
// TODO FestivalStageService를 FestivalController가 의존하게 하는게 좋을듯?
private final FestivalStageService festivalStageService;
private final SchoolRepository schoolRepository;
private final Clock clock;
Expand Down

0 comments on commit 6e51df2

Please sign in to comment.