Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BE] Enum 데이터를 DB로 옮긴다. #810

Merged
merged 10 commits into from
Oct 17, 2024
Merged

[BE] Enum 데이터를 DB로 옮긴다. #810

merged 10 commits into from
Oct 17, 2024

Conversation

JINU-CHANG
Copy link
Contributor

@JINU-CHANG JINU-CHANG commented Oct 16, 2024 •
edited by shin-jisong
Loading

❗ Issue

✨ 구현한 기능

  • Category 스키마 추가
  • Category에 대한 data.sql 추가
  • Category 엔티티 추가
  • Category 레포지토리 추가
  • 깨지는 코드 수정
  • Highlight 스키마 추가
  • Highlight에 대한 data.sql 추가
  • Question에 대한 data.sql 추가
  • Question 스키마 추가
  • Question 엔티티 추가
  • Question 레포지토리 추가
  • 깨지는 코드 수정
  • ERD 업데이트

배포방식 결정 이후 해야 할 일

DEV

  • QuestionEntity, CategoryEntity 추후 Question, Category로 이름 변경 필요

PROD

  • 스키마 변경
  • data.sql 수정
  • Enum 데이터 Id 값으로 변환하는 스크립트 실행
  • 배포방식에 맞게 코드 수정

📢 논의하고 싶은 내용

🎸 기타

@JINU-CHANG
refactor: Category Enum 엔티티로 변경
9c88b32
@JINU-CHANG
feat: Question, Highlight 테이블 및 초기 데이터 생성
9495eb6
@JINU-CHANG
feat: Question, Highlight 엔티티 추가
b84ec77
@JINU-CHANG
feat: ChecklistQuestion 엔티티에 QuestionEntity 추가 및 테스트 수정
15e0d65
@JINU-CHANG
test: QuestionFixture 리팩토링
f7a1b0c
@JINU-CHANG
feat: CustomChecklist 클래스에 QuestionEntity 추가
65a75ee
@JINU-CHANG
feat: data.sql, schema.sql 내용 추가
dc7c83e
@JINU-CHANG
Merge remote-tracking branch 'origin/dev-be' into refactor/769-enum-db
6561394 
# Conflicts:
#	backend/bang-ggood/src/main/java/com/bang_ggood/global/exception/ExceptionCode.java
#	backend/bang-ggood/src/main/resources/schema.sql
#	backend/bang-ggood/src/test/java/com/bang_ggood/checklist/controller/ChecklistE2ETest.java
#	backend/bang-ggood/src/test/java/com/bang_ggood/user/UserFixture.java
@JINU-CHANG
fix: dev-be와 머지
19c340a
@JINU-CHANG JINU-CHANG changed the title Refactor/769 enum db [BE] Enum 데이터를 DB로 옮긴다. Oct 16, 2024
shin-jisong
shin-jisong approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@shin-jisong shin-jisong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
추후에 TODO로 달린 것만 바로 반영해 주시면 될 것 같네요 👍
ERD도 수정해야 할 것 같은데 바쁘시면 나중에 같이 진행해 봐요!

tkdgur0906
tkdgur0906 approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@tkdgur0906 tkdgur0906 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다~~

@shin-jisong shin-jisong merged commit ea63ea3 into dev-be Oct 17, 2024
2 checks passed
@shin-jisong shin-jisong deleted the refactor/769-enum-db branch October 17, 2024 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tkdgur0906 tkdgur0906 tkdgur0906 approved these changes

@shin-jisong shin-jisong shin-jisong approved these changes

@tsulocalize tsulocalize Awaiting requested review from tsulocalize

Assignees

@tsulocalize tsulocalize

@JINU-CHANG JINU-CHANG

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JINU-CHANG @tkdgur0906 @shin-jisong @tsulocalize