-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FE] 새 방 비교 페이지를 완성하고 방 선택 페이지를 만들어 연결한다. #973
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
f501172
fix: 복구
ooherin aee63d6
Merge branch 'dev-fe' of https://github.com/woowacourse-teams/2024-ba…
ooherin e660e67
Merge branch 'dev-fe' of https://github.com/woowacourse-teams/2024-ba…
ooherin 800f221
fix: 충돌 해결
ooherin cf910ac
Merge branch 'dev-fe' of https://github.com/woowacourse-teams/2024-ba…
ooherin eef7c37
feat: 체크리스트 작성 페이지 퍼블리싱
ooherin a60e94a
feat: 방 비교 선택 페이지 데이터 로직 완성
ooherin 6091a54
feat: 옵션 디테일 모달 완성
ooherin 0cb6a29
feat: 체크리스트 카테고리 디테일 쿼리 생성
ooherin 29b99e9
feat: 카테고리 디테일 질문 모달 완성
ooherin 4411edb
fix: 불필요한 페이지 코드 삭제 및 Badge 컴포넌트 리팩토링
ooherin 7b288ff
feat: 불필요한 컴포넌트 Marker 공용 컴포넌트로 만들어서 통합
ooherin 9b495e4
fix: HightLight 컴포넌트 폰트 크기 확장 및 적용
ooherin 2981338
feat: 작업 중 불필요한 변경사항 삭제
ooherin 7421ae8
Merge branch 'dev-fe' of https://github.com/woowacourse-teams/2024-ba…
ooherin 08731cd
fix: 디테일 아코디언 컴포넌트 리팩토링 및 적용
ooherin fe893f2
feat: 방 비교 선택 페이지 스켈레톤 생성
ooherin 7aef9a4
fix: 불필요한 커밋 수정
ooherin 293e07b
fix: 변경된 api url 로 수정
ooherin 4e0c44b
fix: 비교 백엔드 api 연결 및 라우팅 수정
ooherin 8282257
Merge branch 'dev-fe' of https://github.com/woowacourse-teams/2024-ba…
ooherin d54d68f
refactor: roomComparePage의 접근성을 높이기 위해 리팩토링
ooherin a726810
fix: attribute 타입의 범위를 작게 수정
ooherin 5cbcaaf
fix: 지하철 섹션 비교 ui 수정
ooherin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
import fetcher from '@/apis/fetcher'; | ||
import { BASE_URL, ENDPOINT } from '@/apis/url'; | ||
|
||
export const getRoomCompare = async (roomId1: number, roomId2: number) => { | ||
const response = await fetcher.get({ url: BASE_URL + ENDPOINT.ROOM_COMPARE(roomId1, roomId2) }); | ||
const data = await response.json(); | ||
return data.checklists; | ||
}; | ||
|
||
export const getRoomCategoryDetail = async ({ roomId, categoryId }: { roomId: number; categoryId: number }) => { | ||
const response = await fetcher.get({ url: BASE_URL + ENDPOINT.ROOM_CATEGORY_DETAIL(roomId, categoryId) }); | ||
const data = await response.json(); | ||
return data; | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 changes: 0 additions & 22 deletions
22
frontend/src/components/ChecklistDetail/CategoryAccordion.tsx
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,9 +4,10 @@ import Divider from '@/components/_common/Divider/Divider'; | |
import Layout from '@/components/_common/layout/Layout'; | ||
import { useTabContext } from '@/components/_common/Tabs/TabContext'; | ||
import ChecklistQuestionItem from '@/components/NewChecklist/ChecklistQuestion/ChecklistQuestion'; | ||
import ChecklistQuestionAnswers from '@/components/NewChecklist/ChecklistQuestion/ChecklistQuestionAnswers'; | ||
import MoveNextButton from '@/components/NewChecklist/MoveNextButton'; | ||
import useChecklistStore from '@/store/useChecklistStore'; | ||
import { flexColumn } from '@/styles/common'; | ||
import { flexColumn, flexRow, flexSpaceBetween } from '@/styles/common'; | ||
import theme from '@/styles/theme'; | ||
import { ChecklistQuestion } from '@/types/checklist'; | ||
|
||
|
@@ -28,11 +29,15 @@ const EditChecklistQuestionTemplate = () => { | |
const isLastQuestion = questions?.questions.length - 1 === index; | ||
return ( | ||
<> | ||
<ChecklistQuestionItem | ||
key={`${currentTabId}-${question.questionId}`} | ||
question={question} | ||
answer={answer} | ||
/> | ||
<S.QuestionBox key={question.questionId}> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ChecklistQuestionItem을 제사용하기 위해 해당 컴포넌트의 Wrapper 를 제거하여 리팩토링하였습니다. |
||
<ChecklistQuestionItem | ||
key={`${currentTabId}-${question.questionId}`} | ||
question={question} | ||
width={'80%'} | ||
/> | ||
<ChecklistQuestionAnswers title={question.title} answer={answer} questionId={question.questionId} /> | ||
</S.QuestionBox> | ||
|
||
{!isLastQuestion && <Divider />} | ||
</> | ||
); | ||
|
@@ -56,6 +61,15 @@ const S = { | |
gap: 0.2rem; | ||
`, | ||
QuestionBox: styled.div` | ||
position: relative; | ||
width: 100%; | ||
${flexRow} | ||
${flexSpaceBetween} | ||
padding: 1.6rem; | ||
border-radius: 0.8rem; | ||
|
||
box-sizing: border-box; | ||
|
||
background-color: ${({ theme }) => theme.palette.white}; | ||
`, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
불필요한 depth 를 줄였습니다.