[BE] 체크리스트 방 비교 기능을 구현한다. #979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…course-teams/2024-bang-ggood into feat/974-checklist-compare
JINU-CHANG
requested changes
Nov 20, 2024
| @@ -74,6 +77,12 @@ public ResponseEntity<ChecklistsPreviewResponseV1> readLikedChecklistsPreviewV1( | |||
| return ResponseEntity.ok(checklistManageService.readLikedChecklistsPreviewV1(user)); | |||
| } | |||
|
|
|||
| @GetMapping("/v1/checklists/compare") | |||
There was a problem hiding this comment.
REST API에서는 자원 중심으로 설계하기 때문에 행위는 HTTP 메서드로 나타내고 URI는 명사구를 사용한다고 알고 있는데, 다른 방식으로 표현해보는 건 어떤가요 ???🤔
Comment on lines
+98
to
+101
| int allAnsweredQuestionCount = checklistQuestionRepository.countAnsweredQuestionsByChecklistIdAndCategoryId( | ||
| checklistId, categoryId); | ||
| int goodAnsweredQuestionCount = checklistQuestionRepository.countAnsweredQuestionsByChecklistIdAndCategoryIdAndAnswer( | ||
| checklistId, categoryId, Answer.GOOD); |
There was a problem hiding this comment.
AnsweredQuestions을 먼저 가져오고 Answer.GOOD인 것만 필터링해서 갯수를 확인하면 2번 데이터베이스에 요청을 보내지 않아도 될 것 같아요!
There was a problem hiding this comment.
리팩토링 PR로 반영하겠습니다!!
Comment on lines
+106
to
+109
|
|
||
| double score = ((double) goodAnsweredQuestionCount / allAnsweredQuestionCount) * 100; | ||
| return (int) Math.round(score); | ||
| } |
There was a problem hiding this comment.
비교를 위한 계산 로직이 꽤 중요한 도메인이라고 생각하는데 도메인 내부에서 처리하는 건 어떤가요? 🤔
There was a problem hiding this comment.
리팩토링 PR로 반영하겠습니다!!
Comment on lines
+230
to
+239
| @DisplayName("카테고리 점수 계산 성공 : 답변이 없는 경우") | ||
| @Test | ||
| void calculateCategoryScore_noAnswers() { | ||
| // given & when | ||
| Integer categoryId = QuestionFixture.QUESTION1_CATEGORY1.getCategory().getId(); | ||
| Integer score = checklistQuestionService.calculateCategoryScore(checklist.getId(), categoryId); | ||
|
|
||
| // then | ||
| assertThat(score).isEqualTo(0); | ||
| } |
There was a problem hiding this comment.
계산 로직을 가진 도메인이 있다면 해당 테스트도 도메인 테스트로 변경할 수 있을 것 같아요~
There was a problem hiding this comment.
리팩토링 PR로 반영하겠습니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Issue
✨ 구현한 기능
체크리스트 방 비교 기능 구현
📢 논의하고 싶은 내용
🎸 기타