Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to gutenberg-mobile 1.13.0 #12527

Merged
merged 6 commits into from
Sep 23, 2019
Merged

Update to gutenberg-mobile 1.13.0 #12527

merged 6 commits into from
Sep 23, 2019

Conversation

mchowning
Copy link
Contributor

@mchowning mchowning commented Sep 20, 2019 •
edited by etoledom
Loading

Update gutenberg to v1.13.0 (gutenberg-mobile PR)

Gutenberg Mobile PR: wordpress-mobile/gutenberg-mobile#1351
Gutenberg PR: WordPress/gutenberg#17329
WPAndroid PR: wordpress-mobile/WordPress-Android#10483

To test

  • Smoke test gutenberg editor.

Remaining tasks

- [ ] Add implementation for editorDidAutosave function (Not needed anymore for this release)

  • Update to reference gutenberg-mobile release tag instead of commit hash

Update release notes:

  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@mchowning mchowning added the Gutenberg Editing and display of Gutenberg blocks. label Sep 20, 2019
@mchowning mchowning changed the title Gb/release 1.13.0 Update to gutenberg-mobile 1.13.0 Sep 20, 2019
@mchowning
Copy link
Contributor Author

I needed to update GutenbergViewControl because it did not have the editorDidAutosave function implemented for the GutenbergBridgeDelegate protocol. I just added an empty stub implementation to get this PR building, so we still need to take care of this. I haven't had a chance to look into this much, but it looks like we probably need an update similar to what @daniloercoli did on the Android side. I'll try to take a look at this later this afternoon after I grab some lunch, but if @etoledom or @SergioEstevao want to take a look, I could use the help. 😄

@daniloercoli
Copy link
Contributor

@mchowning I guess we need to merge this PR here: #12489 that introduces the iOS changes.

@etoledom
Copy link
Contributor

@mchowning I guess we need to merge this PR here: #12489 that introduces the iOS changes.

Yes, we need that one first 🤔
I thought we weren't shipping autosave on this version? From wordpress-mobile/gutenberg-mobile#1351 (comment)

@mchowning
Update release notes for #12467
8768770 
This was previously removed because it was not included in the
gutenberg-mobile 1.12.0 release. Adding this back in now that we're
updating to use the gutenberg 1.13.0 release.
@daniloercoli
Copy link
Contributor

I thought we weren't shipping autosave on this version? From wordpress-mobile/gutenberg-mobile#1351 (comment)

There was a mention to the frozen (1.12.0) branch in the comment mentioned above, that is why i said no to target that branch. Instead this is a new version (1.13.0). It's safe to release the changes now, since it will be included in the next apps cut and tested for 2 weeks before going to the public.

@etoledom etoledom added this to the 13.3 milestone Sep 23, 2019
@etoledom etoledom marked this pull request as ready for review September 23, 2019 09:55
etoledom
etoledom approved these changes Sep 23, 2019
View reviewed changes
Copy link
Contributor

@etoledom etoledom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you @mchowning for taking care of this.

I updated the comment on editorDidAutosave to be a bit more explicit about why is it empty.
We have decided to keep the native autosave behavior in place on WPiOS for now.

@etoledom etoledom added Gutenberg Editing and display of Gutenberg blocks. and removed Gutenberg Editing and display of Gutenberg blocks. labels Sep 23, 2019
@etoledom etoledom merged commit 1f5f556 into develop Sep 23, 2019
@etoledom etoledom deleted the gb/release-1.13.0 branch October 2, 2019 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etoledom etoledom etoledom approved these changes

@SergioEstevao SergioEstevao Awaiting requested review from SergioEstevao

Assignees

@mchowning mchowning

@etoledom etoledom

Labels
Gutenberg Editing and display of Gutenberg blocks.
Projects
None yet
Milestone
13.3
Development

Successfully merging this pull request may close these issues.
3 participants
@mchowning @daniloercoli @etoledom