Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Alpha] Hide the keyboard when tapping on non-inputField block #404

Merged
merged 4 commits into from
Dec 19, 2018

Conversation

daniloercoli
Copy link
Contributor

This PR fixes #308 for the Alpha, by dismissing the keyboard (calling blur on the last TextInput field) when the field that now gets the focus is a non-textual field.

Please test extensively on iOS, and Android.

@daniloercoli daniloercoli added this to the Alpha milestone Dec 19, 2018
@daniloercoli daniloercoli requested review from koke and mzorz December 19, 2018 11:44
Copy link
Member

@koke koke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on iOS and Android and it seems to be working fine 👏

Copy link
Contributor

@mzorz mzorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniloercoli
Copy link
Contributor Author

I'd like @hypest review the last commit d99a268 , since introduced a new module to make flow happy.

@koke
Copy link
Member

koke commented Dec 19, 2018

I think you could add the new definitions to the existing libdefs.js file, but this looks OK to me.

@koke
Copy link
Member

koke commented Dec 19, 2018

I'm merging this to make sure it gets there before the merge, feel free to do a follow up PR if you want to change the flow config

@koke koke merged commit 80a70b9 into master Dec 19, 2018
@koke koke deleted the issue/308-hack-hide-keyboard-when-not-required branch December 19, 2018 16:38
@koke koke restored the issue/308-hack-hide-keyboard-when-not-required branch December 19, 2018 16:38
@daniloercoli
Copy link
Contributor Author

Thanks @koke, your suggestion was right. will open a new PR for flow only.

@hypest hypest deleted the issue/308-hack-hide-keyboard-when-not-required branch December 24, 2018 12:38
@hypest
Copy link
Contributor

hypest commented Dec 24, 2018

I'd like @hypest review the last commit d99a268 , since introduced a new module to make flow happy.

👋 @daniloercoli , late to the party but, has this been worked on already perhaps? If not, can't we directly import TextInputState from react-native? I think we won't need to add extra definitions in libdefs.js that way.

@daniloercoli
Copy link
Contributor Author

directly import TextInputState from react-native

We tried that but was not working, since TextInputState is not exported. Looking at docs on Internet, we implemented the suggested way of importing it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants