-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Alpha] Hide the keyboard when tapping on non-inputField block #404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested on iOS and Android and it seems to be working fine 👏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think you could add the new definitions to the existing |
I'm merging this to make sure it gets there before the merge, feel free to do a follow up PR if you want to change the flow config |
Thanks @koke, your suggestion was right. will open a new PR for flow only. |
👋 @daniloercoli , late to the party but, has this been worked on already perhaps? If not, can't we directly import |
We tried that but was not working, since TextInputState is not exported. Looking at docs on Internet, we implemented the suggested way of importing it. |
This PR fixes #308 for the Alpha, by dismissing the keyboard (calling blur on the last TextInput field) when the field that now gets the focus is a non-textual field.
Please test extensively on iOS, and Android.