Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #365

Merged
merged 10 commits into from
Oct 14, 2022
Merged

Update documentation #365

merged 10 commits into from
Oct 14, 2022

Conversation

tomvothecoder
Copy link
Collaborator

Description

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

If applicable:

  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass with my changes (locally and CI/CD build)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have noted that this is a breaking change for a major release (fix or feature that would cause existing functionality to not work as expected)

@tomvothecoder tomvothecoder added the type: docs Updates to documentation label Oct 14, 2022
@tomvothecoder tomvothecoder self-assigned this Oct 14, 2022
@tomvothecoder
Copy link
Collaborator Author

tomvothecoder commented Oct 14, 2022

Hey @chengzhuzhang and @pochedls, there is a section in our documentation that says we are striving for "Support for CF compliant, E3SM non-CF compliant, and common metadata". This line was taken from early in our requirements gathering days.

Can either of you clarify what E3SM non-CF compliant and common metadata are and if is still within scope to support them? So far xCDAT support has primarily been for CF compliant datasets and non-CF datasets with "months since ..." or "years since..." time units.

https://github.com/xCDAT/xcdat#things-we-are-striving-for

@chengzhuzhang
Copy link
Collaborator

Hey @tomvothecoder, E3SM output mostly follows CF-convention and we strive to convert non-compliant items when possible. I think we can rephrase it as: "Support for CF compliant, non-CF compliant but common metadata"?

@pochedls
Copy link
Collaborator

Hey @tomvothecoder, E3SM output mostly follows CF-convention and we strive to convert non-compliant items when possible. I think we can rephrase it as: "Support for CF compliant, non-CF compliant but common metadata"?

This sounds good to me. We might re-phrase to something like: "xcdat supports CF compliant datasets, but will also strive to support datasets with common non-CF compliant metadata."

@lee1043
Copy link
Collaborator

lee1043 commented Oct 14, 2022

I like the way @pochedls rephrased!

@tomvothecoder
Copy link
Collaborator Author

Thanks for the feedback everyone! I followed Steve's rephrased description.

@tomvothecoder tomvothecoder merged commit 7100d42 into main Oct 14, 2022
@tomvothecoder tomvothecoder deleted the docs/363-misc-updates branch October 14, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: docs Updates to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Doc]: Misc. updates
4 participants