This repository has been archived by the owner on May 1, 2024. It is now read-only.
Update ItemsUpdatingScrollMode when element loaded on iOS #10284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfversluis
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Hey @modplug sorry it took a short while! Thank you so much for this first contribution!
Seems to work fine!
rmarinho
approved these changes
Apr 15, 2020
|
Which version will this be released? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
The ItemsViewRenderer on iOS will now update the ItemsUpdatingScrollMode upon loading the element.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
The ItemsViewRenderer on iOS will now update the ItemsUpdatingScrollMode upon loading the element.
There seems to be a timing issue where setting the ItemsUpdatingScrollMode right after creating the CollectionView doesn't fire the OnElementPropertyChanged method in the ItemsViewRenderer.
Before/After Screenshots
Not applicable
Testing Procedure
I've added the different ItemsUpdatingScrollMode modes to the ObservableCodeCollectionViewGallery
PR Checklist