Skip to content
This repository has been archived by the owner on May 1, 2024. It is now read-only.

Fix Grid regressions with text in star rows/columns #12475

Merged
merged 2 commits into from
Oct 21, 2020
Merged

Fix Grid regressions with text in star rows/columns #12475

merged 2 commits into from
Oct 21, 2020

Conversation

hartez
Copy link
Contributor

@hartez hartez commented Oct 13, 2020

Description of Change

Fixes for some regressions on 4.8 with Grid layout. Unconstrained star rows affected by star columns now constrain Labels correctly when measuring to allow the text to grow vertically by the correct amount. Star row/column computations no longer include "unmeasured" (i.e. -1) values in size calculations. Star column calculations now account for absolute column widths and partial star column (e.g. "0.7*") when measuring elements where width/height are interdependent (e.g., Labels).

Also adds automated tests for the regressed scenarios.

Issues Resolved

API Changes

None

Platforms Affected

  • Core/XAML (all platforms)

Behavioral/Visual Changes

None

Before/After Screenshots

Not applicable

Testing Procedure

Automated tests

PR Checklist

  • Targets the correct branch
  • Tests are passing (or failures are unrelated)

@jsuarezruiz jsuarezruiz added a/layout i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often Core labels Oct 14, 2020
@hartez
Copy link
Contributor Author

hartez commented Oct 20, 2020

The iOS 13 test failures are with the WebView Cookie tests - nothing to do with these changes.

@modplug
Copy link
Contributor

modplug commented Oct 20, 2020

When can we expect a service release with this fix included?

@nZeus
Copy link

nZeus commented Dec 9, 2020

Can we know when is it going to be released, please?

@MitchBomcanhao
Copy link

MitchBomcanhao commented Dec 10, 2020

Can we know when is it going to be released, please?

@nZeus this fix was released one month ago?

@GerriGoorIrex
Copy link

I'm still having problems in version 4.8.0.1687 with a Grid in a ListView. If a column is set to auto or star the row height is not calculated correctly. While in version 4.8.0.1560 this is working.

@nZeus
Copy link

nZeus commented Dec 16, 2020

Can we know when is it going to be released, please?

@nZeus this fix was released one month ago?

Hi @MitchBomcanhao, indeed, it's been released. Release 4.8.0-sr5 corresponds to v4.8.0.1687. This confused me.

We currently cannot upgrade Xamarin.Forms to 4.8.0.1687, because of the bug with Height="X*" (see #12900 and #13034). I'll keep an eye on those issues instead.

@nZeus
Copy link

nZeus commented Dec 28, 2020

Seems to be fixed in 4.8.0.1821. cc: @GerriGoorIrex

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
4.8.0 regression on 4.8.0 a/collectionview a/grid a/layout a/listview Problems with the ListView/TableView Core i/high Completely doesn't work, crashes, or is unusably slow, has no obvious workaround; occurs less often i/regression m/high impact ⬛ t/bug 🐛
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants