-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Fix Grid regressions with text in star rows/columns #12475
Conversation
The iOS 13 test failures are with the WebView Cookie tests - nothing to do with these changes. |
When can we expect a service release with this fix included? |
Can we know when is it going to be released, please? |
@nZeus this fix was released one month ago? |
I'm still having problems in version 4.8.0.1687 with a Grid in a ListView. If a column is set to auto or star the row height is not calculated correctly. While in version 4.8.0.1560 this is working. |
Hi @MitchBomcanhao, indeed, it's been released. Release We currently cannot upgrade Xamarin.Forms to 4.8.0.1687, because of the bug with |
Seems to be fixed in 4.8.0.1821. cc: @GerriGoorIrex |
Description of Change
Fixes for some regressions on 4.8 with Grid layout. Unconstrained star rows affected by star columns now constrain Labels correctly when measuring to allow the text to grow vertically by the correct amount. Star row/column computations no longer include "unmeasured" (i.e. -1) values in size calculations. Star column calculations now account for absolute column widths and partial star column (e.g. "0.7*") when measuring elements where width/height are interdependent (e.g., Labels).
Also adds automated tests for the regressed scenarios.
Issues Resolved
API Changes
None
Platforms Affected
Behavioral/Visual Changes
None
Before/After Screenshots
Not applicable
Testing Procedure
Automated tests
PR Checklist