This repository has been archived by the owner on May 1, 2024. It is now read-only.
[Android] Numeric keyboard should be able to process all available keys #396
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Android numeric keyboard displayed 14 keys (https://developer.xamarin.com/recipes/cross-platform/xamarin-forms/controls/choose-keyboard-for-entry/), but only the digits along with the dot character were processed. This ensures that all characters can be input.
Steps to verify changes:
KeyListener
should listen for the 14 keys.KeyListener
should be set to the proper listenerInputType = InputTypes.ClassNumber | InputTypes.NumberFlagSigned | InputTypes.NumberFlagDecimal
does not work (tested on S6 / M) probably because of Android fragmentation.IMO, entry validation should be left to the developer (see user's request). The simplest way to validate numbers is with
double.Parse(text, CultureInfo.CurrentCulture)
, but for whatever reason custom validation might be required or the UI might be tasked to react as the entry changes from a valid number to an invalid number or vice versa.You might see this bug while testing the sample. Please note that this is an existing bug.
Bugs Fixed