This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
XP-119 Fix gRPC testing setup so that it can run on macOS #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
requested review from
wilk10,
atymoshchuk,
PanicButtonPressed and
bartlomiej-matejczy
|
Please check if the tests are working on your machine (macOS) |
wilk10
suggested changes
Jan 13, 2020
There was a problem hiding this comment.
thanks, awesome!!
it works also after XP-373 (re-enable tests after sdk/fl back and forth) (i merged 119 on top of 373). my only concern is that i think import sys in test_grpc is now unused (but apparently it's not picked up by pylint). can you please check?
on macos it's running as intended now. |
pylint would mark it, if it were configured correctly, right now it only checks |
|
@wilk10 Good catch! I removed it. |
janpetschexain
previously approved these changes
Jan 13, 2020
wilk10
previously approved these changes
Jan 13, 2020
Robert-Steiner
dismissed stale reviews from PanicButtonPressed and wilk10
via
a90830e
Robert-Steiner
force-pushed
the
feature/XP-119-fix-grpc-tests-on-macos
branch
from
2a41f0b to
a90830e
Compare
Robert-Steiner
force-pushed
the
feature/XP-119-fix-grpc-tests-on-macos
branch
from
a90830e to
431bdba
Compare
PanicButtonPressed
approved these changes
Jan 13, 2020
rsaffi
pushed a commit
that referenced
this pull request
Jan 23, 2020
* XP-337 Clean up docs before generation (#188) * XP-229 Update Readme.md (#189) * XP-255 update codeowners and authors in setup (#195) * XP-265 move benchmarks to separate repo (#193) * XP-243 remove flags from xain-fl codebase * XP-255 update codeowners and authors in setup (#195) * XP-257 cleanup cproto dir (#198) * XP-261 move tests to own dir (#197) * XP-168 update setup.py (#191) * DO-35 📰 ✨ Add placeholder for e2e. Update CI for gitflow * XP-241 remove legacy participant and sdk dir (#199) * DO-17 🐳 ✨ Add Dockerfiles, dockerignore and docs (#202) * XP-354 Remove proto files (#200) * XP-385 Fix docs badge (#204) * Xp 273 scripts cleanup (#206) * XP-357 make controller parametrisable (#201) * XP-384 remove unused files (#209) * Do 43 docker compose minio (#208) * XP-374 Clean up docs (#211) * XP-271 fix pylint issues (#210) * XP-424 Remove unused packages (#212) * DO-49 🐳 ✨ Create initial buckets (#213) * Xp 373 add sdk as dependency in fl (#214) * XP-433 Fix docker headings (#218) * XP-119 Fix gRPC testing setup so that it can run on macOS (#217) * XP-422 ai metrics (#216) * XP-308: store aggregated weights in S3 buckets (#215) * XP-436 Reinstate FINISHED heartbeat from Coordinator (#219) * XP-208 model sum aggregator as a mock for testing * XP-208 add test integrating P and C * XP-208 add identity controller as a mock for test * XP-208 small typo in id-controller docstring * XP-208 add coordinator test fixture with mocked components * XP-208 test for top-level function start_participant * XP-308: print debugging information for spurious failure * XP-208 join monitor_thread to confirm response to terminate_event * XP-208 change mock patch string to object called rather than defined * XP-208 model sum aggregator as a mock for testing * XP-208 add test integrating P and C * XP-208 add identity controller as a mock for test * XP-208 small typo in id-controller docstring * XP-208 add coordinator test fixture with mocked components * XP-208 test for top-level function start_participant * XP-436 fix bug: coordinator not advertising FINISHED state * XP-436 revert logging level * XP-208 join monitor_thread to confirm response to terminate_event * XP-208 change mock patch string to object called rather than defined * XP-436 suggested documentation fixes from review * XP-208 mock the store (following rebase) * XP-208 fix import * XP-208 test_start_participant: mark as slow, comment on aggregation * XP-480 revise message names (#222) * XP-499 Remove conftest, exclude tests folder (#223) * XP-333 Replace numproto with xain-proto (#220) * XP-505: docstrings cleanup (#224) * XP-508 Replace circleci badge (#225) * XP-510 allow for zero epochs on cli (#227) * XP-498: more generic shebangs (#229) * XP-505: cleanup docstrings in xain_fl.coordinator (#228) * Prepare release of v0.3.0 (matching version with `xain-sdk` and `xain-proto`) (#230) Co-authored-by: Anastasiia Tymoshchuk <[email protected]> Co-authored-by: Daniel Kravetz <[email protected]> Co-authored-by: Felix Reichel <[email protected]> Co-authored-by: Anselmo Sampietro <[email protected]> Co-authored-by: Robert Steiner <[email protected]> Co-authored-by: Corentin Henry <[email protected]> Co-authored-by: janpetschexain <[email protected]> Co-authored-by: kwok <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
XP-119 Fix gRPC testing setup so that it can run on macos
Summary
Are there any open tasks/blockers for the ticket?
No
Reviewer checklist
Reviewer agreement:
Merge request checklist
XP-XXX <a description in imperative form>.XP-XXX <a description in imperative form>.Code checklist
XP-XXX-<a_small_stub>.