-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
@@ -348,15 +348,15 @@ where the request and response data are given as the following protobuf messages | |||
message StartTrainingRoundRequest {} | |||
|
|||
message StartTrainingRoundResponse { | |||
repeated xain_proto.numproto.NDArray weights = 1; | |||
xain_proto.np.NDArray weights = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i understand this has been implemented elsewhere in this way (xain_proto
repo), but i would advise against using the np
abbreviation because that is a convention reserved for the actual numpy
package, which may cause some confusion. but it doesn't quite fall under the scope of this PR, i guess
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np
was chosen explicitly as it stands for numpy
(not numproto
) to indicate directly that this is a protobuf implementation of numpy, as well as the associated utilites.
"""An abstract class that defines the API a store must implement. | ||
|
||
""" | ||
"""An abstract class that defines the API a store must implement.""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if the only changes to this file are about the docstrings and don't change any functionality, then i wouldn't include this in the PR, otherwise it may cause confusion in the commit history
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since it doesn't change the content/meaning of the docstring but only the formatting, i consider this simple cleanup which shouldn't require a dedicated ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! looks pretty good. only some comment for readability (i didn't test it locally though)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just minor comments, otherwise looks fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but it seems the branch has to be rebased first.
7a8f4a2
5f361b8
to
7a8f4a2
Compare
References
Summary
hellonumproto
examples and teststested by running a dockerized coordinator and local participants on both sdk examples.
Are there any open tasks/blockers for the ticket?
Reviewer checklist
Reviewer agreement:
Merge request checklist
XP-XXX <a description in imperative form>
.XP-XXX <a description in imperative form>
.Code checklist
XP-XXX-<a_small_stub>
.