This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
PB-569 first aggregator test #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robert-Steiner
changed the title
little-dude
reviewed
Mar 28, 2020
little-dude
approved these changes
Mar 28, 2020
Robert-Steiner
force-pushed
the
PB-569-aggregator-tests
branch
2 times, most recently
from
a5c606d to
28cc910
Compare
Robert-Steiner
force-pushed
the
PB-569-aggregator-tests
branch
from
28cc910 to
9e700d0
Compare
little-dude
reviewed
Mar 31, 2020
little-dude
suggested changes
Mar 31, 2020
There was a problem hiding this comment.
That looks good! I think the associated types in the ByteAggregator could be simplified a little. Also the commit history is a bit weird. To fix that easily: git fetch upstream && git reset upstream/master && git add rust/src && git commit -m 'your message' (feel free to split that into multiple commits)
Robert-Steiner
force-pushed
the
PB-569-aggregator-tests
branch
from
9326541 to
6878ae3
Compare
little-dude
reviewed
Mar 31, 2020
little-dude
approved these changes
Mar 31, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary