Skip to content
This repository has been archived by the owner on Aug 30, 2022. It is now read-only.

metrics feature flag #489

Merged
merged 3 commits into from
Aug 5, 2020
Merged

metrics feature flag #489

merged 3 commits into from
Aug 5, 2020

Conversation

finiteprods
Copy link
Contributor

@finiteprods finiteprods commented Aug 4, 2020

This merge request updates the manifest to support an "opt-in" for a forthcoming feature metrics. Making this feature optional means we can avoid the overhead (both at run time and compile time) associated with this feature when we don't need it on.

There is also a small test app bin/hello-metrics.rs to illustrate how to use it in our library code, which will be removed in the final PR.
By default, without the feature:

$ cargo run --bin hello-metrics
Hello World!

With the feature:

$ cargo run --features "metrics" --bin hello-metrics
Hello World!
Influx says Hi!

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #489 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #489      +/-   ##
==========================================
- Coverage   51.56%   51.49%   -0.07%     
==========================================
  Files          63       63              
  Lines        3105     3105              
==========================================
- Hits         1601     1599       -2     
- Misses       1504     1506       +2     
Impacted Files Coverage Δ
rust/src/state_machine/phases/update.rs 66.66% <0.00%> (-1.91%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abda18a...f5f0d5c. Read the comment docs.

@finiteprods finiteprods marked this pull request as ready for review August 4, 2020 10:06
Copy link
Contributor

@Robert-Steiner Robert-Steiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good👍 I think we can already merge it so that you can use it in the metrics settings task

@finiteprods finiteprods merged commit 4c7fcd6 into master Aug 5, 2020
@finiteprods finiteprods deleted the metric_feature_flag branch August 5, 2020 07:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants