-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typescript changes #996
Merged
Merged
Typescript changes #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhiode
reviewed
Dec 3, 2019
036d9c1
to
34a7ec8
Compare
To be honest I'm not sure on how |
KnisterPeter
previously approved these changes
Dec 5, 2019
I would say, lets try it out. If it does work as we hope/expect it to work, then we are a lot faster than without isolated modules. |
34a7ec8
to
737b824
Compare
KnisterPeter
approved these changes
Dec 6, 2019
jhiode
approved these changes
Dec 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
📦 v12
Apply this label to a pull request, if it has to be cherry-picked to the v12.x-branch after merging.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hops-typescript
'stsconfig.json
compilerOptions
target
- andmoduleResolution
-properties aren't overwritten by the usertranspileOnly
andcompilerOptions.isolatedModules
totrue
for the dev-serverI'm overall not happy with how the checks are done in the
diagnosis()
-hook & don't lead to an error. Does anyone have a good idea to improve that?Also the
transpileOnly
-feature doesn't lead tocompilerOptions.isolatedModules
being set totrue
anymore since this PR, that apparently fixed this issue. Maybe we don't want to enable it either, but I'm not able to decide this now. 😑