Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript changes #996

Merged
merged 5 commits into from
Dec 6, 2019
Merged

Typescript changes #996

merged 5 commits into from
Dec 6, 2019

Conversation

herschel666
Copy link
Contributor

  • strongly recommend to extend hops-typescript's tsconfig.json
  • check, that the compilerOptions target- and moduleResolution-properties aren't overwritten by the user
  • speed up incremental builds by setting transpileOnly and compilerOptions.isolatedModules to true for the dev-server

I'm overall not happy with how the checks are done in the diagnosis()-hook & don't lead to an error. Does anyone have a good idea to improve that?

Also the transpileOnly-feature doesn't lead to compilerOptions.isolatedModules being set to true anymore since this PR, that apparently fixed this issue. Maybe we don't want to enable it either, but I'm not able to decide this now. 😑

@herschel666 herschel666 added the 📦 v12 Apply this label to a pull request, if it has to be cherry-picked to the v12.x-branch after merging. label Dec 3, 2019
@herschel666 herschel666 force-pushed the typescript-changes branch 2 times, most recently from 036d9c1 to 34a7ec8 Compare December 4, 2019 14:15
@KnisterPeter
Copy link
Contributor

To be honest I'm not sure on how isolatedModules behaves in ts-loader. I've used it without webpack only.
But I'm really sure that for example parcel is integrating with typescript that way. But it may have some special side effects with webpack.

KnisterPeter
KnisterPeter previously approved these changes Dec 5, 2019
@KnisterPeter
Copy link
Contributor

I would say, lets try it out. If it does work as we hope/expect it to work, then we are a lot faster than without isolated modules.

@herschel666 herschel666 merged commit 8bf474c into master Dec 6, 2019
@herschel666 herschel666 deleted the typescript-changes branch December 6, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 v12 Apply this label to a pull request, if it has to be cherry-picked to the v12.x-branch after merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.2.1 = npm error "Could not find file:" ...
3 participants