Patch openssl-sys crate to v0.9.92 #709
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression in openssl-sys exists where libatomic is dynamically linked
for i686-linux-android targets. sfackler/rust-openssl#2163
The result is dynamically linked symbols are included in the binary header link table:
The presence of these symbols breaks Android CI tests for i686 targets with the following error:
This is fixed in the openssl-sys fork at https://github.com/xmtp/rust-openssl on the branch clone-v0.9.92, which is pinned
to that version. Version 0.9.92 statically links libatomic for i686 targets. Once this is addressed upstream we can remove the patch.
A patch is required as openssl-sys is a dependency crate. A fork is required because it is not possible to patch to an older version of the same source.