Skip to content
This repository has been archived by the owner on Feb 28, 2025. It is now read-only.

Fetch Key Packages #55

Merged
merged 13 commits into from
Feb 8, 2024
Merged

Fetch Key Packages #55

merged 13 commits into from
Feb 8, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 2, 2024

Closes #20

requires xmtp/didethresolver#41 to be merged first, for query manipulation

@insipx insipx marked this pull request as ready for review February 7, 2024 16:53
Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0580a61) 86.14% compared to head (5bc97f5) 89.07%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #55      +/-   ##
==========================================
+ Coverage   86.14%   89.07%   +2.93%     
==========================================
  Files          10       10              
  Lines         231      293      +62     
==========================================
+ Hits          199      261      +62     
  Misses         32       32              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this looks really good. Ready to go, but I would ask what is the definition of 'Completed' in this context.

@insipx insipx merged commit 200068d into main Feb 8, 2024
6 checks passed
@insipx insipx deleted the insipx/fetch-key-packages branch February 8, 2024 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Contact Operations – Registry – FetchKeyPackages
3 participants