Skip to content
This repository has been archived by the owner on Feb 28, 2025. It is now read-only.

Some bugs during demo development #66

Merged
merged 4 commits into from
Feb 13, 2024
Merged

Some bugs during demo development #66

merged 4 commits into from
Feb 13, 2024

Conversation

insipx
Copy link
Contributor

@insipx insipx commented Feb 13, 2024

  • fix bug where we generated two wallets in methods & gateway context leading to insufficient funds error
  • use correct signer wallet in endpoints wallet_address and balance
  • add a registry-localnet binary that launches an anvil instance with the registry already deployed. Useful for local testing E2E with libxmtp, without touching Sepolia
  • generally add some more logging, especially around gas price use when calling the DIDRegistry contract

- fix bug where we generated two wallets in methods & gateway context
  leading to insufficient funds error
 - add a `registry-localnet` binary that launches an anvil instance with
   the registry already deployed
- generally add some more logging
Copy link

codecov bot commented Feb 13, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (18f851d) 91.16% compared to head (938199d) 89.86%.

Files Patch % Lines
registry/src/lib.rs 33.33% 10 Missing ⚠️
lib-xps/src/lib.rs 0.00% 2 Missing ⚠️
xps/src/main.rs 80.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   91.16%   89.86%   -1.31%     
==========================================
  Files          12       12              
  Lines         419      444      +25     
==========================================
+ Hits          382      399      +17     
- Misses         37       45       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@jac18281828 jac18281828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@insipx insipx merged commit 66af436 into main Feb 13, 2024
4 of 6 checks passed
@insipx insipx deleted the insipx/demo branch February 13, 2024 22:51
Copy link
Contributor

@37ng 37ng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already merged but would like to point out that registry-localnet could be renamed to localnet because we might add more deployed smart contracts there. otherwise lgtm

@insipx
Copy link
Contributor Author

insipx commented Feb 13, 2024

It's already merged but would like to point out that registry-localnet could be renamed to localnet because we might add more deployed smart contracts there. otherwise lgtm

I actually gotta do a follow up anyway because i screwed up the DID_REGISTRY address, good callout!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants