This repository has been archived by the owner on Dec 27, 2022. It is now read-only.
Refactor #53
Closed
Refactor #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs to client and display
|
@valendesigns please give a 👍 and I'll move forward with using it as the basis for #15 |
|
I'll take a look in an hour or so just wrapping something up.
|
…nt; ensure data migration accounts for dirty
Check for unauthorized, unrecognized, and invalid settings prior to sanitizing
…b#188 from branch feature/eslint-one-var xwp/wp-dev-lib@0f3058b...30b4b22
Added a toolbar link to edit post screen view.
… into bugfix/saving-menus-issue_2
… into feature/add-frontend-view-link_issue_49
Add front-end view link to post edit screen.
… snapshot values will be added properly
Re-use methods in WP_Customize_Nav_Menus in favor of duplication
Support snapshotting nav menus, nav menu locations, and nav menu items
… into feature/refactor
|
Closing in favor of PR for |
|
New PR to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Over the past week, off-and-on, I've done a deep dive into the snapshots PHP code and I believe I've come up with an improved refactored codebase that cleans out some cruft and improves mantainability.
can_previewmethod.dirtyflag in the post data. We're only storing the changed values. Because of this, we can now simplify the snapshot data to just be the values. We can skip storing asanitizedflag as well, however this needs more discovery.