Avoid bind-attr in tests for newer Ember #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ember 1.13 deprecated bind-attr, and Ember 2.0 removed it. This causes the tests to fail in the ember-release, ember-beta and ember-canary scenarios. The '1.10.1' scenario will fail if `bind-attr` is removed, though. This modifies the `x-favicon.hbs` template to conditionally use `bind-attr` when it must.
bantic
force-pushed
the
remove-bind-attr-for-current-ember-tests
branch
from
6f92641 to
5109510
Compare
|
Thanks! |
|
👍 thanks for the merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ember 1.13 deprecated bind-attr, and Ember 2.0 removed it. This causes
the tests to fail in the ember-release, ember-beta and ember-canary
scenarios. The '1.10.1' scenario will fail if
bind-attris removed,though. This modifies the
x-favicon.hbstemplate to conditionally usebind-attronly when it must.