Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add legend to colors in upgrade-iteractive #3454

Closed
bestander opened this issue May 19, 2017 · 11 comments
Closed

Add legend to colors in upgrade-iteractive #3454

bestander opened this issue May 19, 2017 · 11 comments

Comments

@bestander
Copy link
Member

Do you want to request a feature or report a bug?
improvement

What is the current behavior?

18555248_478165102527699_1583036487_n

Would be nice to explain what read and yellow colors mean

@mohitgarg
Copy link

I would like to help with this issue.

@bestander
Copy link
Member Author

Awesome! Send a PR and cc me

@mohitgarg
Copy link

I am a beginner in OSS. I understood the issue but can you walk me through the files and point me in the right direction. I would really appreciate it!

@bestander
Copy link
Member Author

Sure, are you comfortable making changes to Yarn source code, building it and running any command?
The code for upgrade-interactive is here https://github.com/yarnpkg/yarn/blob/master/src/cli/commands/upgrade-interactive.js

@clarenced
Copy link
Contributor

Hi @bestander, can I contribute to this issue?

@bestander
Copy link
Member Author

bestander commented May 31, 2017 via email

@clarenced
Copy link
Contributor

clarenced commented Jun 1, 2017

Hi @bestander , do you have any idea what message to display for explaining the legend colors? My correction will put a key in src/reporters/lang/en.js to display the content of the message.

@bestander
Copy link
Member Author

bestander commented Jun 1, 2017 via email

@clarenced
Copy link
Contributor

Hi @bestander, here is the PR #3561

@pichouk
Copy link
Contributor

pichouk commented Jun 19, 2017

Just read this issue and seems it can be closed since PR where merged ;)

@bestander
Copy link
Member Author

Thanks for the ping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants