Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve usage NotFoundException for cases with definitions #356

Merged
merged 5 commits into from
May 22, 2024

Conversation

vjik
Copy link
Member

@vjik vjik commented Mar 14, 2024

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues -

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (aeb0856) to head (9234ad9).

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #356   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       161       165    +4     
===========================================
  Files             11        11           
  Lines            466       479   +13     
===========================================
+ Hits             466       479   +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

what-the-diff bot commented Mar 14, 2024

PR Summary

  • Expanded Change Log
    The CHANGELOG.md file has been updated to include the recent enhancement, improving usage for NotFoundException for specified cases.

  • Enhanced Error Handling
    The code dealing with exception handling in the get() method located in the src/Container.php file has been refined. This involved the introduction of a new class NotFoundException within src/NotFoundException.php.

  • Updated Test Assertions
    The message in assertion test for NotFoundException within tests/Unit/CompositePsrContainerOverYiisoftTest.php has been updated to match the changes in the NotFoundException class.

  • Improved Test Coverage
    In the tests/Unit/ContainerTest.php file, new test cases have been introduced for the NotFoundException class. The previous test cases have also been revised for better test coverage.

@vjik vjik requested a review from a team March 14, 2024 09:25
@vjik vjik added the status:code review The pull request needs review. label Mar 14, 2024
@vjik vjik merged commit 0fb49fa into master May 22, 2024
32 checks passed
@vjik vjik deleted the not-found-exception branch May 22, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants