Skip to content
This repository has been archived by the owner on Nov 19, 2019. It is now read-only.

Performance improvements #168

Merged
merged 46 commits into from
Jun 26, 2019
Merged

Performance improvements #168

merged 46 commits into from
Jun 26, 2019

Conversation

jarnovanrhijn
Copy link
Contributor

Great performance improvements

  • Replaced css left & top with translate()
  • Cached widths and heights where possible
  • Replaced new Date() with Date.now()

deviousasti and others added 30 commits May 14, 2019 10:19
@deviousasti
Minor code format
3544338
@deviousasti
Use transform instead of top/left for minor and major labels
800ebce
@deviousasti
Translate current time bar
6619281
@deviousasti
Translate minor line
9befe7a
@deviousasti
Translate major line
b340c5c
@deviousasti
Fix conditional with side-effects
b2379c6
@jarnovanrhijn
replaced top, left right bounding rects to single function
c1d5079
@deviousasti
Merge branch 'master' of https://github.com/jarnovanrhijn/timeline-plus
cac91a2
@deviousasti
Test wthout walking prototype chain
7311db7
@deviousasti
Replace copy functions
c543595
@deviousasti
Use classList methods for add/remove css
fb08f8e
@deviousasti
Use native array forEach
00c6816
@jarnovanrhijn
replaced new Date() with Date.now()
ded1e4f
@jarnovanrhijn
cached some heights and widths for perf improvements
0c03d8e
@jarnovanrhijn
Merge https://github.com/deviousasti/timeline-plus
e0caad6
@deviousasti
Fix add/remove classNames implementation
6102997
@deviousasti
One className add/remove per element
a2e9b47
@jarnovanrhijn
cached some more heights and widths
46d2ca4
@jarnovanrhijn
replaced new Date() with Date.now()
01e3faa
@jarnovanrhijn
moved height and width after guard to avoid unnecessary calculations
a6bb728
@deviousasti
Add repositionXY function to util
df83a11
@deviousasti
Simplify BoxItem positioning code into more readable code
130ca00 
Make BoxItem use css transforms
@deviousasti
Merge branch 'master' of https://github.com/jarnovanrhijn/timeline-plus
700a1e0 
Merge lib/util.js with jarno's changes
@deviousasti
Fix util.translate
d8a23f0
@deviousasti
Move BoxItem node to microtasks queue
6a24528
@deviousasti
Labels and data axis limited to text content instead of HTML
77342ae
@jarnovanrhijn
moved variables below guard to avoid undefined or unnecessary calcula…
4386b5b 
…tions
@jarnovanrhijn
replaced left in center dom with translateY
a609953
@deviousasti @jarnovanrhijn
Move BoxItem node to microtasks queue
74450cb
@deviousasti @jarnovanrhijn
Labels and data axis limited to text content instead of HTML
35b2a4c
jarnovanrhijn and others added 15 commits May 23, 2019 08:32
@jarnovanrhijn
replaced left with translateX in RangeItem.js
28487e0
@jarnovanrhijn
added translate support for rtl
46c5d07
@jarnovanrhijn
Revert "replaced left in center dom with translateY"
ef60ccc 
This reverts commit a609953.
@jarnovanrhijn
Merge https://github.com/deviousasti/timeline-plus
279e8b5
@jarnovanrhijn
reverted rtl transform
1ec042d
@jarnovanrhijn
destructuring offset assignments
268f160
@jarnovanrhijn
dom center style translate added
fd90963
@jarnovanrhijn
reverted innerHTML
0246a96
@jarnovanrhijn
rtl transform support
3772587
@jarnovanrhijn
tooltip placement centered, cluster items and pointitems position to …
4954f48 
…translate and fixed currentTime translate
@jarnovanrhijn
added repositionXY to point items and fixed boxitem lines
dfcf4dd
@jarnovanrhijn
added support for tooltip while dragging
86c8ac0
@jarnovanrhijn
removed commented out code
d5ed66e
@jarnovanrhijn
fixed disappearing of items when dragging between groups
ded48ce
@yotamberk
Resolve conflict with master
6a59f50
@yotamberk
Copy link
Owner

Sorry for the mistake...

@jarnovanrhijn
Copy link
Contributor Author

@yotamberk haha no problem! I was happy to see it merged for a second because :P i thought you had fixed the glitching issue.

At least we have a fresh start in this PR ;)

@yotamberk
Copy link
Owner

yotamberk commented Jun 8, 2019 •
edited
Loading

I've been playing around with items/backgroundAreasWithGroups.html example dragging a ranged item to the far right near the the last items and playing around touching and untouching the dragged ranged item with the point item on the second group causes really weird behavior. It seems that something with the top calculation (now used with translateY?) might be causing the glitching and bad rendering. I've yet to figure it out exactly. I wanted to share this information while I continue to investigate.

NOTICE: changing the orientation option to top seems to work totally fine with not gliching.

Please continue to inspect the issue too so we can solve this and merge this GREAT pr!

yotamberk
yotamberk suggested changes Jun 23, 2019
View reviewed changes
Copy link
Owner

@yotamberk yotamberk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've finally managed to figure out what's causing the glichiness!!!
Fix these comments and we can merge the changes!

lib/timeline/Core.js
props.borderRootHeight= dom.root.offsetHeight - dom.root.clientHeight;
props.borderRootWidth = dom.root.offsetWidth - dom.root.clientWidth;
props.borderRootHeight = rootOffsetHeight - rootClientHeight;
props.borderRootWidth = rootOffsetWidth - dom.root.clientWidth;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is dom.root.clientWidth not set at the beginning as-well?

@yotamberk
Copy link
Owner

Really awesome work! some of the best work done in this project in a long time!

@yotamberk yotamberk merged commit 66f002c into master Jun 26, 2019
@yotamberk yotamberk deleted the jarnovanrhijn-master branch June 26, 2019 19:26
@yotamberk yotamberk mentioned this pull request Jun 26, 2019
Closed
This was referenced Oct 22, 2019
Closed
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yotamberk yotamberk yotamberk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarnovanrhijn @yotamberk @deviousasti