-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ITV] Update ITV extractor from yt-dlp back-port #30266
[ITV] Update ITV extractor from yt-dlp back-port #30266
Conversation
ITV changes require media stream and subtitles to be taken from different playlist resources. Original commit 4c57dd2 by @sleaux-meaux 3 May 2021
700f295
to
bbde767
Compare
Includes commit 6fbcc16, fix by staubichsauger & pukkandan
bbde767
to
a72aca5
Compare
674f0f2
to
8eabd28
Compare
8eabd28
to
0945174
Compare
* `Mozilla/5.0` avoids read timeout on extraction and 403 on d/l * also detect and report `Episode not found` instead of generic 404
c7250bd
to
c6001d5
Compare
I just want to confirm that testing this branch I was able to download what I was looking to where the current upstream master would just timeout and fail. |
This comment was marked as outdated.
This comment was marked as outdated.
Hi, |
The updated extractor is now in the git master repository code that would be used to make a release. A release built from git master should support ITVX. Also, installing from the git master with pip should do so. |
* https://github.com/ytdl-org/youtube-dl: [ITV] Overhaul ITV extractor (ytdl-org#30266)
* support ITVX URLs (thanks Vangelis66) * support legacy ITV Hub URLs * include extraction fix 4c57dd2 from sleaux-meaux 3 May 2021 * include extraction fix 6fbcc16, fix by staubichsauger & pukkandan * work-around duration parsing pending fix to utils.parse_duration * apply default vanilla UA for pages and media to avoid site blocking * also detect and report `Episode not found` instead of generic 404 * rework ITVBTCCIE with geo-block detection, best effort geo-restriction handling, news article support * fix tests
Please follow the guide below
Before submitting a pull request make sure you have:
In order to be accepted and merged into youtube-dl each piece of code must be in public domain or released under Unlicense. Check one of the following options:
yt-dlp/yt_dlp/extractor/itv.py
)What is the purpose of your pull request?
Description of your pull request and other information
This PR back-ports the ITV extractor from yt-dlp, so incorporating all the latest fixes and facilitating future joint updates.
The PR from #28955 is included for the record as an an interim commit.
In addition the following changes are applied:
:
as a decimal point in duration valueMozilla/5.0
to avoid read time-out in extractionEpisode not found
andWe're really sorry
.Resolves #25796.
Resolves #27582.
Resolves #28906.
Resolves #29620.
Resolves #30265.
Resolves #30578.
Resolves #30994.
Closes #28955.
Now updated for ITVX instead/as well.
Resolves #31363.
Also updated ITV BTCC, handles news articles.
Supersedes, closes #25254.