Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade webpack to v4 #2

Closed
wants to merge 3 commits into from
Closed

upgrade webpack to v4 #2

wants to merge 3 commits into from

Conversation

mamboer
Copy link

@mamboer mamboer commented Apr 9, 2019

  1. Update the project dependencies to the latest
  2. Fix a circular dependency bug

@yunhan0
Copy link
Owner

yunhan0 commented Apr 30, 2019

Thank you for your contribution @mamboer! I'll merge your request once I check it out. Cheers!

@yunhan0
Copy link
Owner

yunhan0 commented Jun 1, 2019

Hi @mamboer, first of all, I wanna say, your upgrade is great! However, to fix the circular dependency, I've noticed few codes are moved to different files. This may lead to confusion. For example, HTTP interceptors has been moved to main.js file. But I think this logic should be kept inside http-common.js.

So I decided to upgrade webpack from 3 to 4 to find out the problem. I got the same Cyclic Error, but turns out it seems to be a problem with a dependency of the html-webpack-plugin. Updating html-webpack-plugin would fix the problem

npm i  html-webpack-plugin@next 

For details about this issue, please check out here.
So, in this way, we don't need to move codes to solve the problem.

Still appreciate a lot to your effort and contribution!

@yunhan0 yunhan0 closed this Jun 1, 2019
@mamboer
Copy link
Author

mamboer commented Jun 3, 2019

Nice job, cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants