This repository has been archived by the owner on Dec 15, 2020. It is now read-only.
Fix order of arguments in handle_UNSUB #82
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we're ping ponging here. I already fixed that in #74 and #75 The problem in ZOCP was that the forwarding subscription was using reversed order arguments For the unsubscribe this was fixed here: Otherwise the unittests would fail as well I guess? Isn't it that in the nodeeditor the unsubscribe is reversed? Similar to how I fixed the subscribe? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit sphaero@a7ff452 changed (fixed?) the order of arguments in _handle_SUB, but did not change _handle_UNSUB. As a result, unsubscription is broken.
Also updates signal_* examples.