Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redux Dev Tools Extension version 2.16.0 clashing my working code #590

Closed
benson7667 opened this issue Nov 28, 2018 · 16 comments
Closed

Redux Dev Tools Extension version 2.16.0 clashing my working code #590

benson7667 opened this issue Nov 28, 2018 · 16 comments

Comments

@benson7667
Copy link

benson7667 commented Nov 28, 2018

My code is working fine when the extension installed is version 2.15.3 or i removed the redux dev tools extension.

The error msg as below:
Error: You may not call store.getState() while the reducer is executing. The reducer has already received the state as an argument. Pass it down from the top reducer instead of reading it from the store.

Here is my store.js:

import { createStore, applyMiddleware, compose } from 'redux';
import thunk from 'redux-thunk';
import rootReducer from './reducers';

const initialState = {};
const middleware = [thunk];

/* eslint-disable no-underscore-dangle */
const composeEnhancers = window.__REDUX_DEVTOOLS_EXTENSION_COMPOSE__ || compose;
/* eslint-enable */

const store = createStore(
  rootReducer,
  initialState,
  composeEnhancers(applyMiddleware(...middleware))
);

export default store;

@benson7667 benson7667 changed the title Redux Dev Tools Extension version 2.17.0 clashing my working code Redux Dev Tools Extension version 2.16.0 clashing my working code Nov 28, 2018
@jithinkmatthew
Copy link

jithinkmatthew commented Nov 28, 2018

Getting the same issue
Chrome Version: 70.0.3538.110 (Official Build) (64-bit)
MacOs High Sierra : v10.13.6
Redux Dev Tools Extension version 2.16.0

@danivivriti
Copy link

danivivriti commented Nov 28, 2018

Getting same error, exact same configs of @jithinkmatthew, removing plugin seems only fix for me at the moment.

@felthy
Copy link

felthy commented Nov 28, 2018

I've also been investigating this. In my case at least, the error only seems to occur when dispatching an action immediately after creating the store. If I don't do that, actions dispatched later seem to be ok. I've narrowed the cause down to this line:

filteredActionIds.push(store.liftedStore.getState().nextActionId);

which was altered 9 hours ago in commit 5f94fc0. So this is only triggered when getMaxAge() is called with a liftedAction param.

@matzxrr
Copy link

matzxrr commented Nov 28, 2018

Same as #588

@felthy
Copy link

felthy commented Nov 28, 2018

Ah yes #588 (comment) beat me to it!

@matzxrr
Copy link

matzxrr commented Nov 28, 2018

Has more information, but that issue is really noisy with the +1s all over the place.

@felthy
Copy link

felthy commented Nov 28, 2018

And even #588 was a dupe of #587

@nuclearspike
Copy link

Recommended simplest action: Disable extension and subscribe to this issue and issue 588 and 587 to know when you can re-enable.

Otherwise, follow instructions in issue 588 to disable 2.16 and manually download the 2.15.5 zip extension and manually add it to Chrome if you just can't wait. #588 (comment)

@saadbinsaeed
Copy link

Revert back to the previous version v2.15.5

  • Download redux-devtool-extension
  • Extract the zip
  • Type chrome://extensions into the url
  • toggle on developer mode on the top right of the page.
  • Click on the Load Unpacked button. After clicking the button, Select the extracted folder.

Hope it will help :)

@zalmoxisus
Copy link
Owner

2.16.1 is available on Crome Store. Please let me know if it helps.

@Tenemo
Copy link

Tenemo commented Nov 28, 2018

Fixed the issue for me, the application renders without problems now. Thanks for the quick update!

@nitimmerman
Copy link

hmm, still the same issue for me:

core.js:1673 ERROR TypeError: Cannot read property 'whitelist' of undefined
    at isFiltered (<anonymous>:1:5016)
    at Object.x [as send] (<anonymous>:1:73900)
    at DevtoolsExtension.notify (extension.ts:111)
    at ScanSubscriber.StoreDevtools.liftedAction$.pipe.Object.state [as accumulator] (devtools.ts:82)
    at ScanSubscriber._tryNext (scan.js:61)
    at ScanSubscriber._next (scan.js:54)
    at ScanSubscriber.Subscriber.next (Subscriber.js:54)
    at WithLatestFromSubscriber._next (withLatestFrom.js:66)

@manklu
Copy link

manklu commented Nov 28, 2018

@nitimmerman That's #589

@951565664
Copy link

watch

There's subscribe button for this on the side panel. And it doesn't send notifications to everyone.

Sorry, I left a comment that was useless, I have deleted it.

@zalmoxisus
Copy link
Owner

@nitimmerman that's fixed in last version, refer to #589.

@nitimmerman
Copy link

thanks! I've already commented in #589 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests