Decouple our fs module from details of the Worktree #110
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make it a more direct shim for the standard FS APIs
maxbrunsfeld
force-pushed
the
fs-refactor
branch
from
e91c818 to
c18ca77
Compare
Anthony-Eid
added a commit
to Anthony-Eid/zed
that referenced
this pull request
Feb 7, 2025
* WIP Co-Authored-By: Piotr Osiewicz <[email protected]> Co-Authored-By: Anthony Eid <[email protected]> * Tear stuff out and make the world burn Co-authored-by: Remco Smits <[email protected]> Co-authored-by: Piotr <[email protected]> * Fix compile errors * Remove dap_store from module list and fix some warnings Module list now uses Entity<DebugSession> to get active modules and handle remote/local state so dap_store is no longer needed * Add Cacheable Command trait This gets rid of ClientRequest or whatever the name was; we don't need to enumerate every possible request and repeat ourselves, instead letting you mark any request as cached with no extra boilerplate. * Add Eq requirement for RequestSlot * Implement DapCommand for Arc<DapCommand> That way we can use a single allocated block for each dap command to store it as both the cache key and the command itself. * Clone Arc on demand * Add request helper * Start work on setting up a new dap_command_handler * Make clippy pass * Add loaded sources dap command * Set up module list test to see if Modules request is called * Fix compile warnings * Add basic local module_list test * Add module list event testing to test_module_list * Bring back as_any_arc * Only reset module list's list state when modules_len changes --------- Co-authored-by: Piotr Osiewicz <[email protected]> Co-authored-by: Anthony Eid <[email protected]> Co-authored-by: Anthony Eid <[email protected]> Co-authored-by: Piotr <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactor that makes the
Fstrait more of a direct shim for the standardfsAPIs, instead of containing some of our implementation logic for the worktree (dealing with CharBag for fuzzy matching, andidfor rename detection).