Keymap changes for editor::JoinLines
#14136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Linux remove ctrl-j - Linux add ctrl-shift-j - MacOS add cmd-shift-j
cla-bot
bot
added
the
cla-signed
llogick
reviewed
Jul 11, 2024
assets/keymaps/default-macos.json
Outdated
Comment on lines
434
to
435
| "ctrl-j": "editor::JoinLines", | ||
| "cmd-shift-j": "editor::JoinLines", |
There was a problem hiding this comment.
I'm not a Mac user so these might be the norm, but they do stand out as dupes.
There was a problem hiding this comment.
I did some archeology and I think you're right.
Adding cmd-shift-j to the Sublime-Mac keybind.
Sublime Linux Default Keymap (2024)
{ "keys": ["ctrl+shift+j"], "command": "join_lines" },
Sublime MacOS Default Keymap (2024)
{ "keys": ["super+shift+j"], "command": "join_lines" },
'cmd-j': 'editor:join-lines'
'ctrl-j': 'editor:join-lines'
VSCode Mac
JetBrain MacOS
JetBrains Windows/Linux
Earlier atom used meta-j (alt-j) and emacs uses M-^ for join-line.
1 task
|
/cherry-pick v0.144.x |
1 similar comment
|
/cherry-pick v0.144.x |
gcp-cherry-pick-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2024
- Linux (default) add ctrl-shift-j - Linux (default) remove ctrl-j - Conflicted with: `"ctrl-j": "workspace::ToggleBottomDock",` - MacOS (sublime) add cmd-shift-j
notpeter
pushed a commit
that referenced
this pull request
Jul 11, 2024
Cherry-picked Keymap changes for `editor::JoinLines` (#14136)
This was referenced Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"ctrl-j": "workspace::ToggleBottomDock",JetBrains/Sublime on Windows/Linux already use
ctrl-shift-jReported here:
CTRLshortcuts not working properly on Linux #14085 (comment)Release Notes:
editor::JoinLinesto ctrl-shift-j (Linux)