Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable toolchain venv in new terminals #21388

Merged

Conversation

sn1c
Copy link
Contributor

@sn1c sn1c commented Dec 1, 2024

Fixes part of issue #7808

This venv should be the one we automatically activate when opening new terminals, if the detect_venv setting is on.

Release Notes:

  • Enable toolchain virtual environment in new terminals

Copy link

cla-bot bot commented Dec 1, 2024

We require contributors to sign our Contributor License Agreement, and we don't have @sn1c on file. You can sign our CLA at https://zed.dev/cla. Once you've signed, post a comment here that says '@cla-bot check'.

@sn1c
Copy link
Contributor Author

sn1c commented Dec 1, 2024

@cla-bot check

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Dec 1, 2024
Copy link

cla-bot bot commented Dec 1, 2024

The cla-bot has been summoned, and re-checked this pull request!

@sn1c sn1c changed the title Enable toolchain venv in terminal Enable toolchain venv in new terminals Dec 1, 2024
@osiewicz osiewicz self-assigned this Dec 1, 2024
@sn1c sn1c requested a review from osiewicz December 2, 2024 22:30
@osiewicz osiewicz merged commit 1270ef3 into zed-industries:main Dec 3, 2024
12 checks passed
@osiewicz
Copy link
Contributor

osiewicz commented Dec 3, 2024

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants