docs: Improve edit prediction tab conflict section
#25493
+27
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Danilo Leal <[email protected]>
cla-bot
bot
added
the
cla-signed
agu-z
added a commit
that referenced
this pull request
Feb 24, 2025
Closes #25406 ### Problem Users have been confused about requiring `alt-tab` instead of just `tab` in cases where they don't have a completions menu open (see issue above). When they insert a newline and are in leading whitespace, they expect to be able to accept a prediction with just `tab`, but doing so increasing the indentation instead. This PR changes the behavior in so a modifier is only required if the cursor isn't already at the right indentation level based on the surrounding block. In this case, `tab` would increase the indentation and the prediction would get interpolated, allowing the user to press `tab` again to accept it. We also updated the docs to break down this behavior: #25493 ### Before https://github.com/user-attachments/assets/91fe6193-dddd-43c1-8c26-0f4648bdc3fa ### After https://github.com/user-attachments/assets/671041bf-bf22-46a3-8466-b19b3e7dd6a0 Release Notes: - edit predictions: Do not require a modifier key when indentation is correct according to its surrounding block Co-authored-by: Danilo Leal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be merged when #25491 is released
Release Notes: