Fix false pointer relocations in data breaking shiftability #2296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove debug prints from matDL build script * matDL build rule: Allow specifying global/local scope
encounter
reviewed
Jan 29, 2025
hatal175
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DTK detects bytes that look like pointers in unlinked TUs as relocations, these have to be marked as
norelocfor those unlinked TUs to remain unchanged when modding.When PAL/other versions are added later they'll also need this fixed, you can search in DTK's asm files for this regex to find relocations that probably aren't real:
\.4byte .*\+0x