#2283 - Review StringsManager class

Library/Backends/ZendEngine3/StringsManager.php

@@ -9,30 +9,19 @@
  * the LICENSE file that was distributed with this source code.
  */
 
+declare(strict_types=1);
+
 namespace Zephir\Backends\ZendEngine3;
 
 use Zephir\StringsManager as BaseStringsManager;
 
 use function Zephir\file_put_contents_ex;
 
 /**
- * Class StringsManager.
- *
  * Manages the concatenation keys for the extension and the interned strings
  */
 class StringsManager extends BaseStringsManager
 {
-    /**
-     * List of headers.
-     *
-     * @var array
-     */
-    protected $concatKeys = [
-        'vv' => true,
-        'vs' => true,
-        'sv' => true,
-    ];
-
     /**
      * Adds a concatenation combination to the manager.
      *
@@ -45,10 +34,8 @@ public function addConcatKey($key)
 
     /**
      * Generates the concatenation code.
-     *
-     * @return array
      */
-    public function genConcatCode()
+    public function genConcatCode(): void
     {
         $code = '
 #ifdef HAVE_CONFIG_H
@@ -209,14 +196,4 @@ public function genConcatCode()
         file_put_contents_ex($contents, 'ext/kernel/concat.h');
         file_put_contents_ex($code, 'ext/kernel/concat.c');
     }
-
-    /**
-     * Obtains the existing concatenation keys.
-     *
-     * @return array
-     */
-    public function getConcatKeys()
-    {
-        return $this->concatKeys;
-    }
 }

Library/StringsManager.php

@@ -42,9 +42,9 @@ public function addConcatKey(string $key)
     /**
      * Generates the concatenation code.
      *
-     * @return array
+     * @return void
      */
-    abstract public function genConcatCode(): array;
+    abstract public function genConcatCode(): void;
 
     /**
      * Obtains the existing concatenation keys.