Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static property reference bug #1904

Closed
zhaoyanliang8 opened this issue Aug 8, 2019 · 6 comments
Closed

static property reference bug #1904

zhaoyanliang8 opened this issue Aug 8, 2019 · 6 comments
Labels
bug

Comments

@zhaoyanliang8
Copy link

see pull request #1903

zend_update_static_property() has been modified in php7.3
https://github.com/php/php-src/blob/PHP-7.2.21/Zend/zend_API.c#L4070-L4106
https://github.com/php/php-src/blob/PHP-7.3.8/Zend/zend_API.c#L4080-L4102

but merge changes to php7.2 may cause php to crash sometimes
@sergeyklay sergeyklay added the bug label Sep 25, 2019
@sergeyklay
Copy link
Contributor

@dreamsxin Could you please take a look

@dreamsxin
Copy link
Contributor

@zhaoyanliang2 你能解决这个问题么？

@dreamsxin dreamsxin mentioned this issue Sep 26, 2019
Merged
3 tasks
@sergeyklay
Copy link
Contributor

Fixed in the development branch. Feel free to open a new issue if the problem appears again. Thank you for the bug report.

@sergeyklay sergeyklay mentioned this issue Oct 5, 2019
Merged
@sergeyklay
Copy link
Contributor

sergeyklay commented Oct 5, 2019 •
edited
Loading

I open this again because changes proposed in the #1927 leads to segmentation fault. For more see: #1941 (comment) and #1954

@sergeyklay sergeyklay reopened this Oct 5, 2019
@sergeyklay
Copy link
Contributor

@dreamsxin Could you please take a look

@dreamsxin dreamsxin mentioned this issue Oct 6, 2019
Closed
3 tasks
dreamsxin added a commit to dreamsxin/zephir that referenced this issue Nov 6, 2019
@dreamsxin
Fix zephir-lang#1904
2183ffe
@Jeckerson
Copy link
Member

Closing due legacy version support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@dreamsxin @sergeyklay @Jeckerson @zhaoyanliang8