Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zephir stubs shouldn't add 'void' return type hint #1977

Closed
sergeyklay opened this issue Oct 17, 2019 · 0 comments · Fixed by #1978
Closed

Zephir stubs shouldn't add 'void' return type hint #1977

sergeyklay opened this issue Oct 17, 2019 · 0 comments · Fixed by #1978
Labels
enhancement Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details

Comments

@sergeyklay
Copy link
Contributor

As a far as Zephir supports PHP 7.0 the stubs command should generate methods with void return type hint:

- public function foo(): void
+ public function foo()
  {
  }

Currently this work so only if PHP 7.0 is used by generating stubs.
@sergeyklay sergeyklay added Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details enhancement labels Oct 17, 2019
JellyBrick added a commit to JellyBrick/zephir that referenced this issue Oct 17, 2019
@JellyBrick
Temporary fix zephir-lang#1977
ef760dd
@JellyBrick JellyBrick mentioned this issue Oct 17, 2019
Merged
3 tasks
sergeyklay added a commit that referenced this issue Oct 17, 2019
@sergeyklay
Merge pull request #1978 from JellyBrick/patch-4
200e5c6 
Temporary fix #1977
dreamsxin pushed a commit to dreamsxin/zephir that referenced this issue Nov 6, 2019
@JellyBrick @dreamsxin
Temporary fix zephir-lang#1977
3c78ba8
@fagai fagai mentioned this issue Nov 25, 2020
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Temporary fix #1977 JellyBrick/zephir
1 participant
@sergeyklay