Update property exception #1916
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #1916 +/- ##
=============================================
Coverage ? 33.6%
Complexity ? 8249
=============================================
Files ? 559
Lines ? 44596
Branches ? 0
=============================================
Hits ? 14988
Misses ? 29608
Partials ? 0 |
Nitpick-CI
reviewed
Sep 20, 2019
| class PropertyUpdateTest extends TestCase | ||
| { | ||
|
|
||
| public function testUpdate11() { |
There was a problem hiding this comment.
Opening brace should be on a new line
Nitpick-CI
reviewed
Sep 20, 2019
|
|
||
| } | ||
|
|
||
| } |
There was a problem hiding this comment.
- Expected 1 blank line at end of file; 2 found
- The closing brace for the class must go on the next line after the body
|
@chrysanthemum Could you please fix codestyle errors |
fix bug: #1915
|
@sergeyklay Thank you very much! I made a new PR, is that ok? |
|
Fixed in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
In raising this pull request, I confirm the following:
Thanks