Bugfix | 1907 stubs for Exceptions

.php_cs.dist

@@ -29,6 +29,7 @@ $finder = PhpCsFixer\Finder::create()
         'ext',
         'ide',
         'templates/ZendEngine3',
+        'unit-tests/sharness',
     ])
     ->notPath('#unit-tests/fixtures/stubs/.*#');
 

Library/Stubs/Generator.php

@@ -140,7 +140,10 @@ protected function buildClass(ClassDefinition $class, string $indent): string
                 );
             }
 
-            $source .= ' extends '.($extendsClassDefinition->isBundled() ? '' : '\\').trim($extendsClassDefinition->getCompleteName(), '\\');
+            $hasAliasForExtends = $class->getAliasManager()->isAlias($extendsClassDefinition->getShortName());
+
+            $source .= ' extends '.($hasAliasForExtends || $extendsClassDefinition->isBundled() ? '' : '\\');
+            $source .= $hasAliasForExtends ? $extendsClassDefinition->getShortName() : $extendsClassDefinition->getCompleteName();
         }
 
         if ($implementedInterfaces = $class->getImplementedInterfaces()) {

unit-tests/fixtures/stubs/issue1922/config.json → unit-tests/fixtures/stubs/issues/config.json

@@ -1,6 +1,6 @@
 {
     "namespace": "stubs",
-    "name": "stubs",
+    "name": "issue_ext",
     "description": "",
     "author": "",
     "version": "0.0.1",

unit-tests/fixtures/stubs/issues/stubs/exception.zep

@@ -0,0 +1,20 @@
+/**
+ * This file is part of the Zephir.
+ *
+ * (c) Zephir Team <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Stubs;
+
+use Throwable;
+
+/**
+ * Exceptions for the Collection object
+ */
+class Exception extends \Exception implements Throwable
+{
+    public function __construct() {}
+}

unit-tests/fixtures/stubs/issue1778/stubs/test.zep → unit-tests/fixtures/stubs/issues/stubs/issue_1778.zep

@@ -9,7 +9,7 @@
 
 namespace Stubs;
 
-use Fixtures\Ide_Stubs\Interfaces\DiInterfaceExample;
+use Psr\Http\Message\RequestInterface;
 
 /**
  * Test Class Example Description
@@ -20,22 +20,22 @@ use Fixtures\Ide_Stubs\Interfaces\DiInterfaceExample;
  *    'param' => 42
  * ];
  *
- * $example = new Test($container, $config);
+ * $example = new Issue_1778($request, $config);
  * </code>
  */
-class Test
+class Issue_1778
 {
     const PROPERTY_EXAMPLE = "test_property";
 
-    /** @var <DiInterfaceExample> */
-    private _container;
+    /** @var <RequestInterface> */
+    private request;
 
     /** @var array */
     protected config;
 
-    public function __construct(<DiInterfaceExample> container, array config)
+    public function __construct(<RequestInterface> request, array config)
     {
-        let this->_container = container;
+        let this->request = request;
         let this->config = config;
     }
 

unit-tests/fixtures/stubs/issues/stubs/issue_1907.zep

@@ -0,0 +1,22 @@
+/**
+ * This file is part of the Zephir.
+ *
+ * (c) Zephir Team <[email protected]>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Stubs;
+
+use Throwable;
+use Stubs\Exception;
+
+/**
+ * Generated Stub should have `extends Exception` without slash
+ * because we using import for this class with FQN
+ */
+class Issue_1907 extends Exception implements Throwable
+{
+    public function __construct() {}
+}

unit-tests/fixtures/stubs/issue1922/stubs/test.zep → unit-tests/fixtures/stubs/issues/stubs/issue_1922.zep

@@ -1,6 +1,6 @@
 namespace Stubs;
 
-class Test
+class Issue_1922
 {
     public function getVar(string! key) -> var | null
     {

unit-tests/sharness/t0005-stubs.sh

@@ -7,10 +7,34 @@ source ./setup.sh
 
 # See: https://github.com/phalcon/zephir/issues/1922
 test_expect_success "Should properly generate type hint" "
-  cd $FIXTURESDIR/stubs/issue1922 &&
+  cd $FIXTURESDIR/stubs/issues &&
   zephirc generate --no-ansi 2>&1 >/dev/null &&
   zephirc stubs --no-ansi 2>&1 >/dev/null &&
-  test_cmp expected/Test.zep.php ide/0.0.1/Stubs/Test.zep.php
+  test_cmp expected/Issue_1922.zep.php ide/0.0.1/Stubs/Issue_1922.zep.php
+"
+
+# See: https://github.com/phalcon/zephir/issues/1778
+test_expect_success "Should properly namespace imports (use block)" "
+  cd $FIXTURESDIR/stubs/issues &&
+  zephirc generate --no-ansi 2>&1 >/dev/null &&
+  zephirc stubs --no-ansi 2>&1 >/dev/null &&
+  test_cmp expected/Issue_1778.zep.php ide/0.0.1/Stubs/Issue_1778.zep.php
+"
+
+# See: https://github.com/phalcon/zephir/issues/1907
+test_expect_success "Should properly generate Namespace for extends" "
+  cd $FIXTURESDIR/stubs/issues &&
+  zephirc generate --no-ansi 2>&1 >/dev/null &&
+  zephirc stubs --no-ansi 2>&1 >/dev/null &&
+  test_cmp expected/Exception.zep.php ide/0.0.1/Stubs/Exception.zep.php
+"
+
+# See: https://github.com/phalcon/zephir/issues/1907
+test_expect_success "Should properly generate Namespace for extends (slash)" "
+  cd $FIXTURESDIR/stubs/issues &&
+  zephirc generate --no-ansi 2>&1 >/dev/null &&
+  zephirc stubs --no-ansi 2>&1 >/dev/null &&
+  test_cmp expected/Issue_1907.zep.php ide/0.0.1/Stubs/Issue_1907.zep.php
 "
 
 test_done