Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix | 1495 regexp escape string #1969

Merged
merged 2 commits into from
Oct 13, 2019
Merged

Conversation

AlexNDRmac
Copy link
Member

Hello!

  • Type: bug fix
  • Link to issue: 1495

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist

  • I wrote some tests for this PR

  • I updated the CHANGELOG

  • Added slashes for regex string when generate C-code

  • Added tests

Thanks

@AlexNDRmac AlexNDRmac requested a review from sergeyklay October 13, 2019 09:07
@codecov
Copy link

codecov bot commented Oct 13, 2019

Codecov Report

Merging #1969 into development will decrease coverage by <.01%.
The diff coverage is 0%.

@@                Coverage Diff                @@
##             development    #1969      +/-   ##
=================================================
- Coverage          31.01%   31.01%   -0.01%     
  Complexity          8260     8260              
=================================================
  Files                561      561              
  Lines              46870    46871       +1     
=================================================
  Hits               14538    14538              
- Misses             32332    32333       +1

@sergeyklay sergeyklay merged commit 48328af into development Oct 13, 2019
@sergeyklay sergeyklay deleted the bugfix/1495-regexp-escapes branch October 13, 2019 09:23
@sergeyklay
Copy link
Contributor

Thank you

@mruz
Copy link
Contributor

mruz commented Mar 10, 2020

let e = "\e"

is escaped now

-ZVAL_STRING(&e, "\e");		
+ZVAL_STRING(&e, "\\e");

so colors in ice console stopped working
https://github.com/ice/framework/blob/3667503adc7efb128ed8d56e46b0ef9b0e24577e/build/php7/ice/cli/console.zep.c#L289

@sergeyklay sergeyklay mentioned this pull request Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants