Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2283 - Fix multi return types stubs #2297

Merged
merged 10 commits into from
Oct 3, 2021

Conversation

Jeckerson
Copy link
Member

@Jeckerson Jeckerson commented Oct 2, 2021

Hello!

  • Type: bug fix

In raising this pull request, I confirm the following:

  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I updated the CHANGELOG

Small description of change:

Thanks

@Jeckerson Jeckerson self-assigned this Oct 2, 2021
By removing .php files and require each to get AST array
@codecov
Copy link

codecov bot commented Oct 2, 2021

Codecov Report

Merging #2297 (c260d04) into development (bcb9db3) will increase coverage by 0.02%.
The diff coverage is 19.72%.

@@               Coverage Diff                @@
##             development   #2297      +/-   ##
================================================
+ Coverage           8.09%   8.11%   +0.02%     
+ Complexity          8632    8591      -41     
================================================
  Files                358     357       -1     
  Lines              22307   22224      -83     
================================================
- Hits                1805    1803       -2     
+ Misses             20502   20421      -81     

@Jeckerson Jeckerson marked this pull request as ready for review October 2, 2021 22:48
@Jeckerson Jeckerson requested review from AlexNDRmac and niden October 2, 2021 22:48
@Jeckerson Jeckerson added this to the 0.14.1 milestone Oct 2, 2021
@AlexNDRmac AlexNDRmac added the Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details label Oct 3, 2021
@AlexNDRmac
Copy link
Member

@Jeckerson pls check php-cs-fixer log into static analysis job

@Jeckerson Jeckerson modified the milestones: 0.14.1, 0.15.0 Oct 3, 2021
@Jeckerson Jeckerson added hacktoberfest-accepted and removed Hacktoberfest See https://hacktoberfest.digitalocean.com/ for participants details labels Oct 3, 2021
@AlexNDRmac AlexNDRmac merged commit ad311cb into development Oct 3, 2021
@AlexNDRmac AlexNDRmac deleted the #2283-fix-multi-return-types-stubs branch October 3, 2021 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Multiple return types generates wrong @return in docblock and its return, in stubs
2 participants