This repository has been archived by the owner on Oct 25, 2023. It is now read-only.
Hide autocompleter suggestions on message submit #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a call to `MessageComposer.hideSuggestions()` in the `onMessageSubmit` function so that the autocompleter is always closed after a message is sent. To Reproduce ------------------ On master, create a message like ":D" and send the message. This will trigger the autocompleter to show up and suggest emojis, but after the message is sent, the autocompleter will still be visible. On this branch, sending the same message will close the autocompleter after the message is sent. Fix zhukov#1203
|
I need this :) |
|
Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a call to
MessageComposer.hideSuggestions()in theonMessageSubmitfunction so that the autocompleter is always closed after amessage is sent.
To Reproduce
On master, create a message like ":D" and send the message. This will trigger
the autocompleter to show up and suggest emojis, but after the message is sent,
the autocompleter will still be visible.
On this branch, sending the same message will close the autocompleter after the
message is sent.
Fix #1203