-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nedis TRV ZBHTR20WT - Tuya _TZE200_ne4pikwm
#3816
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #3816 +/- ##
=======================================
Coverage 90.96% 90.96%
=======================================
Files 327 327
Lines 10606 10607 +1
=======================================
+ Hits 9648 9649 +1
Misses 958 958 ☔ View full report in Codecov by Sentry. |
7943686
to
b2c3252
Compare
hello, any chance this change gets merged for a HA 2025.2 release? |
Can you confirm it's working for you? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this! It allowed me to get my thermostat working in Home Assistant :)
However, I had to make some changes to make it fully work. Firstly, though, I want to mention that I'm new to Home Assistant and this repo so maybe my changes are not correct - but they seem to be working for me. Also, I have the _TZE200_ne4pikwm
thermostat and have only tested my changes on that one.
I think you forgot to add the frost protection switch. Here's my proposed code for it:
.tuya_switch(
dp_id=10,
attribute_name="frost_protection",
translation_key="frost_protection",
fallback_name="Frost protection",
)
Thanks for the feedback, I'm focused on fixing the saswell TRVs that broke during the last release, but when that's complete I'll update this and let you test again. |
to be honest, it was a decision making question. I tried to use it as custom quirck , but cant seem to activate that. So if this is possible in next release, i'll stop trying custom quirk. activation If it takes more time, i'll invest a bit more to get custom quirk working. |
c83fcb8
to
6872b63
Compare
I could put this up to a test if somebody can tell me what file I should use as custom quirk? |
You need |
6872b63
to
1b977b9
Compare
Thanks, got it running :) |
got it up now. Just the firmware sensor isnt populating, while it did show something when just paired without the quirk. oh, another item i spotted. I cant set the max heat value |
I didn't expose a max heat DP since it wasn't exposed in z2m. Are you getting a slider for it or just trying to write the attribute directly? If the Tuya app exposes it, we can add it but would need someone to identify the DP, assuming it exists. |
Thanks for pointing that out, we do set them as constant attributes, but I wasn't aware that we generated entities for constant attributes, we shouldn't, they are after all constant. |
agree with that :) |
1b977b9
to
24d39e9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the running state correct or is it inverted? |
See if changing |
They are actually different, system mode is the mode the thermostat is set to, where running state is the actual current state. So we would expect to see system mode on |
Should I change both lines: 131 and 262? |
Try the latest version |
.tuya_switch( | ||
dp_id=106, | ||
attribute_name="leave_home", | ||
translation_key="leave_home", | ||
fallback_name="Leave home", | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something like "Away mode" for the thermostat? If so, I'd probably call it that. It's similar to "schedule mode".
Proposed change
Add Nedis TRV ZBHTR20WT,
_TZE200_ne4pikwm
and_TZE284_ne4pikwm
.Additional information
Closes: #3517
Based on: https://github.com/Koenkk/zigbee-herdsman-converters/blob/09cfce5153d3931c7cc009aa3ae3107d9b394f5c/src/devices/nedis.ts#L10
Checklist
pre-commit
checks pass / the code has been formatted using Black