Added specific pipes property constants #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sonalgoyal
requested changes
Jul 5, 2022
python/zingg/pipes/pipes.py
Outdated
| Pipe.__init__(self, name, "bigquery") | ||
| Pipe.addProperty(self, "viewsEnabled", "true") | ||
| Pipe.__init__(self, name, Format.BIGQUERY.type()) | ||
| Pipe.addProperty(self, JBigQueryPipe.VIEWS_ENABLED, "true") |
There was a problem hiding this comment.
can we add this property by default?
There was a problem hiding this comment.
In Java app, there are no settings for BigQueryPipe,
There was a problem hiding this comment.
Property is no more set here.
sonalgoyal
requested changes
Jul 5, 2022
python/zingg/pipes/pipes.py
Outdated
| @@ -6,46 +6,48 @@ | |||
|
|
|||
| Format = jvm.zingg.client.pipe.Format | |||
| FilePipe = jvm.zingg.client.pipe.FilePipe | |||
| JSnowflakePipe = jvm.zingg.client.pipe.SnowflakePipe | |||
| JBigQueryPipe = jvm.zingg.client.pipe.BigQueryPipe | |||
|
|
|||
| class CsvPipe(Pipe): | |||
| def __init__(self, name): | |||
| Pipe.__init__(self, name, Format.CSV.type()) | |||
| Pipe.addProperty(self, FilePipe.HEADER,"true") | |||
There was a problem hiding this comment.
this is wrong - we can not set header default true. we have to let the user set the values.
There was a problem hiding this comment.
I've removed it now.
navinrathore
force-pushed
the
PipeConstants
branch
from
fe83e27 to
426a38d
Compare
sonalgoyal
requested changes
Jul 6, 2022
|
navinrathore
force-pushed
the
PipeConstants
branch
from
9b2beef to
fa6e107
Compare
|
Merge conflicts resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.